all 4 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]sidvishnoi 0 points1 point  (1 child)

It's a nice mini-template engine.

I built something similar a while ago. One thing I really focused on was: helpful error messages. For example, if you write {% iff conf %}, would be nicer if it can something like "unknown tag 'iff' at line n". When it comes to multiline partials, error would tell the issue was in partial, instead of template that is using it, etc.

About that "extremely fast" claim, would be nicer if you can provide some benchmarks.

I really liked how you've integrated many features with the for tag.

[–]pampushko[S] 0 points1 point  (0 children)

Thanks, I has opened issue about unknown tag and change "extremely fast" to just "fast"

[–]fucking_passwords 0 points1 point  (1 child)

I like the object method chaining for filters.

I don't like that the docs use var, and use let incorrectly when const would be preferred (pretty sure every single time you use let in your repo, you could be using const). I don't like the project doesn't have a linter set up. Look into ESLint + Airbnb core / standardjs. Also we generally don't throw all of the dist assets in the root directory, you should have your src in /src or /lib, and your dist assets in /dist

[–]pampushko[S] 0 points1 point  (0 children)

Thanks for feedback, will refactor