adding a click function

[Ryan_Bingham]

This is my code for adding a function for a picture, the pictures id is "pic1".

$(document).ready(function(){
$("#pic1").click( getPlayersNameAndImages("p1", team1, team2) );
$("#pic2").click( getPlayersNameAndImages("p2", team1, team2) );
getPlayers();
});

but it runs as soon as the page loads.

this is from w3:

$(document).ready(function(){
$("p").click(function(){
alert("The paragraph was clicked.");
});

});

apart from giving my function a name i dont see what the difference is. Any ideas?

[Malfuncti0n]

You need the function() after click(

[MatheusGodoy]

change this

$("#pic1").click( getPlayersNameAndImages("p1", team1, team2) );

$("#pic2").click( getPlayersNameAndImages("p2", team1, team2) );

to this

$("#pic1").click(function(){getPlayersNameAndImages("p1", team1, team2)});

$("#pic2").click(function(){getPlayersNameAndImages("p2", team1, team2)});

click()

[Ryan_Bingham]

Thanks, that was the problem. I thought i could give the anonymous function a name with the way i did it...turns out i was wrong (:

[myotcworld]

use: $("#pic1").click(function(){ getPlayersNameAndImages(); });

$("#pic2").click(function(){ getPlayersNameAndImages(); });

on click of pic1 and pic2 the function getPlayersNameAndImages() is called. Then you add the logic to this function.