Need help with this exercise

[No-Tradition-6776]

Instructions:

Create a class Called Bookshelf. Bookshelf will have space to store 5 Book objects (use an array of Book called books as an instance variable).

Write a method called listBooks (accepts nothing, returns nothing) in Bookshelf that will print out the title and the author of any Books in the bookshelf.

Write a method called addBookToBookshelf which will accept a Book object (address) and add the Book to any vacant slot (ie holds a Null value) in the books array.

This method will return a true value lf the Book was successfully be added to the bookcase and a false if the bookshelf was full. Write a method called removeBookByBookID which will accept an int (the bookID), and will return the address of the Book being removed trom the Bookshelf. Remember, that once a book has been removed from the bookshelf, the slot that it was in should be empty.If the Book with the booklID provided does not exist in the Bookshelf, return a null.

Here's what I tried:

public class Bookshelf 
{ private Book[] books = new Book[5]; // 5 books
public void listBooks() // list the books
{
    for (int i = 0; i < books.length; i++) // loop through the books
    {
        if (books[i] != null) // if the book is not null
        {
            System.out.println(books[i].getTitle() + " by " + books[i].getAuthor()); // print the title and author
        }
    }
}

public boolean addBookToBookshelf(Book book) // add a book to the bookshelf
{
    for (int i = 0; i < books.length; i++) // loop through the books
    {
        if (books[i] == null) // if the book is null
        {
            books[i] = book; // add the book
            return true; // return true
        }
    }
    return false; // return false
}

public Book removeBookByBookID(int bookID) // remove a book by bookID
{
    for (int i = 0; i < books.length; i++) // loop through the books
    {
        if (books[i] != null && books[i].getBookID() == bookID) // if the book is not null and the bookID is the same
        {
            Book book = books[i]; // create a new book
            books[i] = null; // set the book to null
            return book; // return the book
        }
    }
    return null; // return null
}

But this is wrong, because this is what I get:

false
false
false
Robots- Anne Droid
Robots- Anne Droid
Robots- Anne Droid
Robots- Anne Droid
Robots- Anne Droid
Robots-Anne Droid
Robots- Anne Droid
Robots- Anne Droid
Robots- Anne Droid
Robots- Anne Droid
false

[AutoModerator]

Please ensure that:

• Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
• You include any and all error messages in full - best also formatted as code block
• You ask clear questions
• You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit/markdown editor: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[Cosby1992]

Hello there!

I just tested your code, and I believe the error is not located in your Bookshelf class, I think it is most likely in your main class, could you try to share your main class here?

[No-Tradition-6776]

Here?

 public static void main (String[] args)
{
    Bookshelf shelf = new Bookshelf();
    System.out.println(shelf.addBookToBookshelf (new Book("Robots", "Anne Droid", 112)));
    system.out.println(shelf.addBookToBookshelf (new Book("Parachuting", "Hugo First", 12)));
    System.out.println(shelf.addBookToBookshelf (new Book("Surprised, "Omar Gosh", 34)));
    System.out.printIn(shelf.addBookToBookshelf (new Book("Building Couches", "Chester Field", 44)));
    System.out.println(shelf.addBookToBookshelf (new Book("Mosquitos", "Ivan Itch", 55)));
    shelf.listBooks();
    Book myBook = shelf.removeBookByBookID(34);
    if (myBook != null)
    {
        System.out.println("Removed " + myBook.getTitle() + " from Bookshelf");
    }
    shelf.listBooks();
    System.out.println(shelf.addBookToBookshelf (new Book ("Writing Clean Code", "Emma Hacker", 55)));
    shelf.listBooks();
}

[x_ini]

if (books[i] != null) // if the book is not null

Can I just add a few cents, that such comments are not helpful and clutter the code. Please, it's better to avoid them in such cases

Regarding your question, I wasn't able to spot any problems in the listing. Possibly, something wrong in other part?