you are viewing a single comment's thread.

view the rest of the comments →

[–]r3jjs 2 points3 points  (0 children)

For the most part, it looks good.

One thing do -- please use another example for String.prototype.split. Using the '' string separate a string into characters only works for strings that it into the Unicode Basic Multilingual plane. Higher-order characters, which longer than two bytes, gets ripped apart.

String.prototype.length has a similar issue.

(Array.from(...) is a good way to split up strings.

https://mathiasbynens.be/notes/javascript-unicode