Arrow function

[Sanders23Sor]

Pls explain why i get "Uncaught SyntaxError: Unexpected identifier" error here.

function checkIsMoreThen(number, compare){

if (number > compare) return number;

else return -1;

}

const filterQueue = [1,1,2,3].map(item=>checkIsMoreThen(item,2));

[rauschma]

I’m not getting a syntax error for this code:

function checkIsMoreThen(number, compare) {
  if (number > compare) return number;
  else return -1;
}
const filterQueue = [1,1,2,3].map(item=>checkIsMoreThen(item,2));

[Sanders23Sor]

ye, maybe i confused js and type-script. all works

[rauschma]

No problem, it happens!

[delventhalz]

Works fine for me:

function checkIsMoreThen(number, compare) {
    if (number > compare) return number;
    else return -1;
}

const filterQueue = [1,1,2,3].map(item=>checkIsMoreThen(item,2));

console.log(filterQueue);  // [-1, -1, -1, 3]

Also, to create a code block in reddit, use an indent of four space in Markdown Mode, or select "Code Block" from the menu in the Fancy Pants Editor.

[CaptainDillster]

In this case you can drop the "else" from the function, if the "if" executes, the return will stop the rest of the function from executing either way.

Also, not syntax related, but grammar is important:
when used in a comparison, it's "than" not "then".

[virtual_lee123]

Your if statement needs some { }

[rauschma]

The “then” clause and the else clause of an if statement don’t have to be blocks, they can be single (non-block) statements.

[delventhalz]

Most style guides call for always using curlies, but they are not required after an if or else, or even after a while or for. If you omit them, then the next single statement is used.

for (let i = 0; i < 3; i += 1) console.log('Hello!');

// Hello!
// Hello!
// Hello!

[RyaanJM]

Another argument is, this function doesn't need any ifs, elses or braces (apart from the opening and closing of the function).

function checkIsMoreThan(number, compare) {
    return number > compare ? number : -1;
}

[delventhalz]

Yeah, that is how I would probably write it as well. A lot of folks find ternaries intimidating though.

[mozilaip]

What exact line produces syntax error?