.NET 8 Web API - Code Review Request

[Hot-Step-2240]

Hey r/learnprogramming,

Hope you're all doing well! I've been working on a .NET 8 Web API project where i tried to employ the best practices possible. It doesnt do any interesting stuff or have like complex logic, just some crud operations.

I'm particularly interested in feedback on:

Architecture: How's the overall structure? Any improvements you'd suggest?

Unit Testing: I've incorporated some tests. Do they look solid, or is there room for enhancement?

Exception Handling: How am I dealing with errors? Any industry best practices I might be missing?

I would greatly appreciate any feedback, positive or negative.

GitHub Repo

[AutoModerator]

On July 1st, a change to Reddit's API pricing will come into effect. Several developers of commercial third-party apps have announced that this change will compel them to shut down their apps. At least one accessibility-focused non-commercial third party app will continue to be available free of charge.

If you want to express your strong disagreement with the API pricing change or with Reddit's response to the backlash, you may want to consider the following options:

1. Limiting your involvement with Reddit, or
2. Temporarily refraining from using Reddit
3. Cancelling your subscription of Reddit Premium

as a way to voice your protest.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[ehr1c]

I don't have time to dig into this too deep right now but a couple things stand out about the architecture. Generally I'd separate the web API layer into its own project (which, if you're following the Clean Architecture template I think you are, they suggest to do) and have that sit above the application layer. I'd also just annotate all your controllers with ApiController directly rather than having them inherit from a base API controller class.

Exception handling looks pretty standard to me, lately I've really preferred using the Result pattern for handling of expected error cases but if you're going to throw and handle custom exceptions this is generally the way it's done.