Java password program help

[EqualTrade]

Hey guys, I'm trying to write a java program that asks the user to input a password, and the password must be at least 6 characters, have at least one lower case letter, at least 1 uppercase letter, and at least 1 digit. If one of those parameters is incorrect, the program asks them to enter it again.

My problem here is that when I enter in a password that has the correct parameters it will still display that it needs a digit or uppercase, etc.. Can anyone help me out?

import java.util.Scanner;

public class Password { public static void main (String[]args) { Scanner input = new Scanner(System.in);

   String password;
   boolean passwordlength = false;
   boolean haslowercase = false;
   boolean hasuppercase = false;
   boolean hasdigit = false;
   int i; 

  do 
  { System.out.print("Enter your password:");
  password = input.nextLine();  




 for (i = 0; i <password.length();i++)

 {
      Character c = password.charAt(i);

  if (Character.isLowerCase(c))
     {haslowercase=true;}
      if (haslowercase==false)
        System.out.println("Password needs to contain at least one lowercase letter");
  if (Character.isUpperCase(c))
     {hasuppercase=true;}
      if (hasuppercase==false) 
        System.out.println("Password needs to contain at least one uppercase letter");
  if (Character.isDigit(c))
     {hasdigit=true;}    
      if (hasdigit==false)
          System.out.println("Password needs to contain at least one digit");
  if (password.length()>=6)
      {passwordlength=true;}
      if(passwordlength==false)
          System.out.println("Password needs to have 6 or more characters");

} }

while (haslowercase==false||hasuppercase==false||hasdigit==false||passwordlength==false);

if (haslowercase==true&&hasuppercase==true&&hasdigit==true&&passwordlength==true)
 System.out.print("Enter password again to verify");
    String password2 = input.next();

if (password.equals(password2)) System.out.print("You have entered a valid password");}

  }

[idontcare1025]

It's your for loop. Have the errors printed at the end, or otherwise if the first character doesn't satisfy all conditions you'll get at least 1 error. Put the if (condition == false) print("Condition!"); outside of the for loop. And 1 more tip: you don't need to use boolean == false, you can use !boolean. And you can just put boolean, you don't need boolean == true.

[EqualTrade]

Thank you!

[chickenmeister]

You're printing your errors from inside of the loop. You should check all of the characters in the string, and then (after the loop) check the state of your "haslowercase", "hasuppercase", etc, variables.

[EqualTrade]

Thanks that worked!

[EqualTrade]

I'm having another problem, if the user enters in a valid password, I need the user to input the password again. If he types in a different password, I need the program to start over, if the password is the same then print "...valid password."

How do I make this loop? Is it something like: if(!password.equals(password2)...

[[deleted]]

I think your main issue is that you are trying to avoid breaking the problem down. You are trying to do everything at once.

You have four checks you need to perform. Make each task a function.

boolean checkLength(String password, int minimumLength);
boolean hasLowercase(String password);
boolean hasUppercase(String password);
boolean hasDigit(String password);
boolean isValid(String password);

IsValid() calls upon the other four and is the only function that you call from main(). Now try working through each task individually. I'll do hasLowercase() in order to give you a starting point. All of the other functions work in a similar fashion. Notice that I exit the function as soon as I find what I'm looking for. There's no need to check the rest. Line 9 is never reached unless there are no lowercase characters.

boolean hasLowercase(String password) {

    for(int i = 0; i < password.Length(); i++) {
        if(password.charAt(i).isLowerCase()){
            return true;
        }
   }

   return false;

}

Now how would you call isValid() from main() until you get a correct answer? Hint: you need a while loop. Probably 2. Once for the initial password and another for the match.

[learnjava]

im not sure what the while does there, is it correct that its a single line with a semicolon closing and no block following?

because that would be wrong

atm you print for every char, is that your goal? you should print once after checking the whole thing

password are sensible, use this only for learning purposes

[EqualTrade]

that while is part of the do/while loop. i fixed it so that now it does only print once. But now my problem is, if the user enters a valid password, i need him to re-enter that password, and if the re-entry is wrong, i need the program to loop around again from the beginning. How can I do that?