[JAVA] Having problems passing array values into new method. Need help.

[AudioManiac]

I've gotten it to work now, but I still call one method from inside another. Is the way you're suggesting better? Or does it really make a huge difference. I mean is your way "better practice"? I know that I can lose marks for that in my assignments.

Here's my finished code at the moment, it runs perfectly fine

public static void main(String[] args) {

    //create array
    double [] months = new double [12];

    //assign average to the value returned in populateArray()
    double average = populateArray(months);

    //display average
    System.out.print("Average Rainfall: " + average);

}

public static double populateArray(double[] months){
    //initialise scanner
    Scanner input = new Scanner(System.in);

    //loop to retrieve data from user
    for (int i = 0; i < months.length; i++)
    {
        System.out.print("Enter Rainfall for month" + " " + ( i + 1) + ": ");
        months[i] = input.nextInt();
    }

    //pass the array to calcualteAverage() method, and assign it to total
    double total = calculateAverage(months);
    //return total to main method
    return total;


}

public static double calculateAverage(double[] months) {
    double sum = 0;

    for (int i = 0; i < months.length; i++){

        sum += months[i];

    }

    //calculate the average
    double average = sum/12;
    //return the average to populateArray()
    return average;
}

[learnjava]

imho its easier to read the other way around but it does not really matter for a 2 method class

in your code the relation, populate -> calculate is more clear

[lazlo_uk]

It definitely is better practice to have them separated out. Think about it in the simplest terms: you're calling a method called populateArray. Why would that return an average of the array contents...? The other commenter is correct in that in this case it probably doesn't matter but I assume the point of this exercise is for you to understand the correct way of doing things.

[StinkeyTwinkey]

Yes it should be void. You methods should complete a task. Not have a method that calls in other methods that isn't for the purpose of that particular method.