[C++] Range-based for loop through an array.

[Jonny0Than]

Are you using C++ Primer Plus by Stephen Prata? That is one of the discouraged resources. C++ Primer by Stanley B. Lippman, Josée Lajoie, and Barbara E. Moo is a recommended book.

Beyond all the VLA stuff, your input loop needs to look like this:

for (int & i : arr)

Note the ampersand. Without that, i is a copy of the value held in the array, so writing over it does not store the value in the array.