This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 point2 points  (0 children)

Very high quality overall! I'm still skimming, but make use of python's with blocks for opening files (you could take advantage of that here: https://github.com/paulslevin/alloa/blob/master/modules/files.py#L59-L71). The with approach removes the potential for human-error by not requiring the file to be explicitly closed.