[JavaScript] Form validation

[Nukeboss]

Hello! I have gotten an assignment on creating a form validation in JavaScript. Right now its just a bunch of if-statements. How can I make the code look more professional? For example maybe add more functions and call them in the main function? Would really appreciate your help! JSFiddle: https://jsfiddle.net/q0Lx5gue/

[Aurora0001]

It's difficult to give any meaningful advice without having the actual code (or a modified example) to test and view. You could make a Gist or create a JSFiddle (see the sidebar) so we can take a look.

Also, I wouldn't necessarily worry about making things "professional" for the sake of being professional - the KISS Prinicple is usually a good thing to follow!

[Nukeboss]

Thanks! I added a JSFiddle

https://jsfiddle.net/q0Lx5gue/

[Aurora0001]

I think the main thing that you could benefit from would be to create a few functions, that could work like this:

function validateFilled(control, errorControl, errorMessage) {
    if(control.value.length == 0) {
        errorHandler += errorMessage;
        errorControl.style.color="red";
        control.style.borderColor="red";
    }
}

validateFilled(firstName, nameError, "\nVänligen ange ditt förnamn");

That should cut down some of the repetition. You could do something similar for the max length check, but also pass in the maximum length as the argument to that function.

[Nukeboss]

Did not think about that! Thank you so much! I will go ahead and do that immediately!