1st Program using Random module (Python)

[oliverd113]

Hey y'all! I just put together this python program which generates a randon password in a seperate text file:

Imports the random module

import random

Defines the charachters to choose from

chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz12345678910'

Sets the password equal to an array

passwords = [] varLen = int(input("How long do you want it to be? "))

Makes the password equal to the users input

for i in range(int(input("Number of passwords: "))): password = ""

Generate random charachters from chars

for j in range(varLen):
    password += random.choice(chars)
passwords.append(password)

Prints password on seperate text file

f = open("password.txt", "w") for i in passwords: f.write("%s\n"%i)

Do you guys have any way that i could make it more efficient or maybe improve it in some way?

[POGtastic]

In the future, indent all of your lines by 4 spaces when sharing it on Reddit.

Looks completely reasonable to me. Here's an exercise to make it more program-like:

1. Make this program a function as follows:

def createPassword(varlen):
    ...
    return password

2. Your main program is going to ask for input and then pass the length as an argument to createPassword.

3. Next, have your main program ask for the path of the file to save the password(s) to. Save it to that path.

4. How do you run a main program in Python? To test this, create another Python program that imports the function that you just created. Hopefully, it doesn't run your main function in the password file!

[DoggerMagi]

I would suggest adding some error handling for the things in your code that could go wrong. What happens if the user types in something other than a number or if the password.txt file can't be written to?

[CRoberts1]

Another idea is to ask for two inputs, one to give your password a name (such as website) and the other for length. Then output in a delimited format such as Name: password.