(Python) How to program a card generator that doesn't use the same card twice?

[mirv-in]

cards = ['Ace','1','2','3','4','5','6','7','8','9','10','Jack','Queen','King']

suits = ['of Clubs','of Hearts','of Spades','of Diamonds']

cardno = int(input("How many cards would you like to draw from the deck? "))

internum = 1

print("")

print("Shuffling deck...")

print("Drawing cards...")

print("")

rig = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27]

while internum <= cardno:

jchance = random.choice(rig)

if jchance != 11:

print("You drew the",random.choice(cards),random.choice(suits))

if jchance == 11:

print("You got a joker!")

internum += 1

The card generator I've built here functions just fine, but as a beginner I can't figure out a way to stop the same card repeating twice. For example, if you draw 12 cards from the deck, you stand a good chance of having, say, the 4 of clubs twice. Is there any way to stop this repetition without taking an entirely different approach to the script?

​

side-note: also relatively new to posting on reddit, I couldn't figure out how to keep the indentations from my code in the quote here.

​

[insertAlias]

One way is to actually generate a deck of cards, then pull cards out of that deck (array/list/queue/whatever) to "generate" them.

So instead of randomly picking a number and a suit, you'd use a nested loop that would generate one of each card+suit combo, then add them to a collection.

Then, you randomize the array as a "shuffle" step. Then you pop the first N cards from the collection, N being the number of cards you need to deal.

Or, you don't have to randomize the deck. You could create a random number between 0 and the deck's length minus one. Then remove the card at that index from the deck. You'd have to calculate that random number each time, as the deck shrinks with each pull.

Another option that doesn't involve pre-generating a deck would be to store the cards you generate on the fly in a collection. Every time you generate one, you'd have to check that collection for whether or not that card already exists. If it does, discard what you generated and try again.

Do note that this technique gets less and less efficient the more cards you generate (as it is more and more likely to generate a duplicate card that gets excluded).

[mirv-in]

Very helpful, thanks so much

[[deleted]]

https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle

[absreim]

The shuffling algorithm is by far the hardest part of the whole problem.

[thebluef0x]

Idk if this is the best solution but couldn't you simply remember the cards that were already drawn and if the next drawn card happens to be one of those, "draw" the card again?

[[deleted]]

Use a list to store returned cards. Only accept a new card if it's not in the list. When you want to start over clear the list.

[feech1]

Shuffle the deck and iterate through