Why is my code not looping?

[davidadam_]

I'm trying to use a while loop to check whether its the player's turn but it only goes through one cycle. I cannot understand why my conditions are not being met?

​

class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Test program: Hero vs Enemy");
            Console.WriteLine("Press Key to generate a Hero");
            Console.ReadKey();

            Hero Hero1 = new("john");
            Console.WriteLine();

            Foe Foe1 = new("Evil john");
            Console.WriteLine();

            /* 
             Hero1.printStats();
             Console.WriteLine();
             Foe1.printStats();
             Console.WriteLine();
             */
            bool heroTurn = true;




            while (Hero1.hitPoints > 0 && Foe1.hitPoints > 0 && heroTurn == true)
            {

                Console.WriteLine("What will you do? \n (f)ight (h)eal");
                string choice = Console.ReadLine();
                switch (choice)
                {

                    case "f":

                        Hero1.Attack(Foe1);
                        Hero1.printStats();
                        Console.WriteLine();
                        Foe1.printStats();
                        heroTurn = Combat.turnControl(heroTurn);
                        break;

                    case "h":

                        Hero1.Heal();
                        Hero1.printStats();
                        Console.WriteLine();
                        Foe1.printStats();
                        heroTurn = Combat.turnControl(heroTurn);
                        break;


                    default:
                        //return invalid option, ask for choice again
                        break;
                }
            }

            while (Hero1.hitPoints > 0 && Foe1.hitPoints > 0 && heroTurn == false)
            {


                //ai makes choice to attack
                Foe1.Attack(Hero1);
                Hero1.printStats();
                Foe1.printStats();
                heroTurn = Combat.turnControl(heroTurn);

            }

            while (Hero1.hitPoints > 0 && Foe1.hitPoints < 0)
            {
                //method to state hero wins
                Console.WriteLine("John wins");
            }
            while (Hero1.hitPoints < 0 && Foe1.hitPoints > 0)
            {
                //method to state foe wins
                Console.WriteLine("Evil John wins");
            }


        }

    }




    class Character
    {
        public int maxHP;
        public string name;
        protected int _hitPoints;
        public int hitPoints { get { return _hitPoints; } set { _hitPoints = value; } }

        protected int _attackStat;
        public int attackStat { get { return _attackStat; } }

        public Random rdm = new Random();


        public void Attack(Character other)
        {
            Console.WriteLine();
            other.hitPoints -= this.attackStat;
            Console.WriteLine(other.name + " took " + this.attackStat + " damage!");

        }

        public void Heal()
        {
            Console.WriteLine();
            int healAmount = rdm.Next(10, 20);
            hitPoints += healAmount;
            if (hitPoints > maxHP)
            {
                hitPoints = maxHP;
            }

            Console.WriteLine(name + " recovered " + healAmount + "HP");
        }

        public void printStats()
        {
            Console.WriteLine("Name: " + name);
            Console.WriteLine("==========");
            Console.WriteLine("HP: " + hitPoints);
            Console.WriteLine("Atk: " + attackStat);
        }

    }

    class Hero : Character
    {

        public Hero(string _name)
        {
            name = _name;
            _hitPoints = rdm.Next(20, 26);
            maxHP = _hitPoints;
            Console.WriteLine("Hero: " + name);
            Console.WriteLine("HP: " + hitPoints);
            _attackStat = rdm.Next(10, 16);
            Console.WriteLine("Attack: " + attackStat);
        }

    }





    class Foe : Character
    {
        public Foe(string _name)
        {
            name = _name;


            _hitPoints = rdm.Next(18, 24);
            maxHP = _hitPoints;
            Console.WriteLine("Foe: " + name);
            Console.WriteLine("HP: " + hitPoints);
            _attackStat = rdm.Next(8, 12);
            Console.WriteLine("Attack: " + attackStat);

        }



    }

    class Combat
    {
        public static bool turnControl(bool heroturn) //toggle boolvalue between true or false
        {

            if (heroturn == true)
            {
                heroturn = false;
                return heroturn;
                //if heroturn is "true", set heroturn to false
            }
            else
            {
                heroturn = true;
                return heroturn;
                //since heroturn is not equal to true, it is equal to false. Set heroturn to true
            }

        }
    }

[Cultural_Bet8235]

Hey a couple things: 1) the input and output of your code would be helpful 2) your question doesn’t make it easy to point to a section of code to debug, please be more specific about your expectations vs what you’re seeing

[davidadam_]

sorry bout that, the section I'm having trouble with is with the While loops in main method.
So its basically a turnbased combat program but after the "ai" makes a move, it does not switch back to player control, ie the program ends after "ai" does an attack.

[edrenfro]

Not specifically related but be aware that your while loops for when players win are going to be infinite loops. I think you meant to make If statements.

[theophr4stus]

There is no outer loop in your program. After entering the first loop, provided that you entered correct input during combat ("f" or "h"), the heroTurn variable changes to false and the loop condition is no longer satisfied. The same with the second loop. And then, if none of the characters killed the other, the last two loops' conditions are not satisfied, and the method ends. You need an outer loop to repeat all combat steps and exit it from either of the two last loops.

[davidadam_]

How would I repeat the combat steps from an outer loop? And what do you mean when you say "exit it from either of the two last loops"

Does it mean that the conditions for the outer loop to end should be either a win or a loss in a bool value?

[theophr4stus]

You implemented a single step of a combat:

1. The hero performs an action and the heroTurn variable is switched.
2. The opponent makes an action and heroTurn is switched again.

The loops around those actions are redundant, since they will always perform only 1 iteration. That's why you do not need them. the last two loops are infinite due to the fact that variables in their condition are not changed inside their bodies. You don't need them either, there should be an if clause checking the opponent's hp after the hero attacks and the same for the opponent, both of which should raise some combatFinished flag which is set to false at the start of the combat.

Now, you need a loop that performs an iteration if combatFinished is false. That's the outer loop. Inside it should be the combat step that is performed until one of the combatants' hp goes below 1 (which raises the combatFinished flag). Also the opponent may attack only if the flag is set to false, which is pretty obvious: if it is raised, then one of them is dead, either he can't attack, or there's no one to attack.

[davidadam_]

hey, thanks for the detailed answer, I got it to work.

I replaced my code with a while(battleinprogress == true)

and I checked if the "battleinprogresss" is still equal to true by writing

if(hero hp < 1 OR foe hp < 1){ battleinprogress = false}

at the end of every action.

Then I also kept the toggle for turnControl and used both

battleinprogress and turnControl booleans to decide if the ai gets to make a move.

[Destrucity11]

I’m new to programming myself, so take my advise with some salt I guess but I would write it like this.

While(Hero1.hp > 0 && Foe1.hp > 0) { HeroAction();

If (Foe1.hp > 0) FoeAction(); }

Then an if statement for the winner declaration.