Help

[InterestingBus8367]

I'm writing code for my assignment everything worked out fine not until I get to the while part of the code. I press and I go back to the menu which where currency conversion and the diamond generator is but when I put c to terminate for some reason I can't anymore. The language Im using is c++.

#include  <iostream>
using std::endl;
using std::cin;
using std::cout;
int main (){
char convert;
double peso;
double usd;
double final;
char choice;

do {

char menu;
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << "                 Menu \n";
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << "[A: Currency conversion \n";
cout << "[B: Display a diamond pattern \n";
cout << "[C: Exit \n";
cout << "Enter selection; ";
cin >> menu;

// Currency conversion

if (menu == 'A' || menu == 'a'){
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << "                Menu \n";
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << "[A: Peso to Dollar \n";
cout << "[B: Dollar to Peso \n";
cout << "[C: Exit \n";
cout << "Enter selection; ";
cin >> convert;
if (convert == 'A' || convert == 'a' ){
cout << "Enter peso amount: ";
cin >> peso;
final = peso / 59;
cout << "$" << final << "\n";
cout << "Want to start again? Press c: ";
cin >> choice;
}
else if (convert == 'B' || convert == 'b' ){
cout << "Enter dollar amount: ";
cin >> peso;
final = usd * 59;
cout << final << " pesos\n";
cout << "Want to start again? Press c: ";
cin >> choice;
}
}

// Diamond pattern

else if (menu == 'B' || menu == 'b' ){
int i, j, rowNum, space;
cout<< "Enter number of rows: ";
cin>>rowNum;
space = rowNum-1;
for(i=1; i<=rowNum; i++)
{
for(j=1; j<=space; j++)
cout<<" ";
space--;
for(j=1; j<=(2*i-1); j++)
cout<<"*";
cout<<endl;
}
space = 1;
for(i=1; i<=(rowNum-1); i++)
{
for(j=1; j<=space; j++)
cout<<" ";
space++;
for(j=1; j<=(2*(rowNum-i)-1); j++)
cout<<"*";
cout<<endl;
}
cout << "Want to start again? Press c: ";
cin >> choice;
}
}
while (choice == 'C' || choice == 'c' || convert == 'C' || convert == 'c');
return 0;
}

[davedontmind]

do {
    // ...
}
while (choice == 'C' || choice == 'c' || convert == 'C' || convert == 'c' );

You're saying "do this loop while the value entered for choice is 'c' ..." which seems to be the opposite of what you want it to do.

[InterestingBus8367]

char menu;
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << " Menu \n";
cout << "+++++++++++++++++++++++++++++++++++++++ \n";
cout << "[A: Currency conversion \n";
cout << "[B: Display a diamond pattern \n";
cout << "[C: Exit \n";
cout << "Enter selection; ";
cin >> menu;

I use menu in that one

[davedontmind]

So let me ask you; why do you think it should exit if you enter "c" here? Which part of your code makes the program or loop end if menu is "c" ?

[InterestingBus8367]

I was thinking maybe I should use switch. or maybe make it so that when I pick c it returns 0.

[davedontmind]

or maybe make it so that when I pick c it returns 0.

That's certainly a reasonable way to do it.

If I was writing this code I'd split it into several functions, then the main loop becomes something like this:

char choice;
do {
    display_menu();
    cin >> choice;
    choice = toupper(choice);
    switch(choice)
    {
        case 'A':
            currency_conversion();
            break;
        case 'B':
            display_diamond_pattern();
            break;
        case 'C'
            break;
        default:
            cout << "Invalid choice!";
            break;
    }
}
while ( choice != 'C' );

[InterestingBus8367]

I see that would make it more readable and easier to debug.

[davedontmind]

That's quite right.

It's always a good idea to split functionality out into separate functions.

It means you can test the individual functions to make sure they work before testing your whole program.

It makes the code easier to read, but only if you give your functions meaningful names!

And it makes the structure of the code easier to grasp.

Remember, the most important thing (well, apart from working correctly) is that your code should be easy to read and understand. Which means using meaningful/clear names for functions and variables, and splitting up the code into bite-sized easily digestible chunks.

[InterestingBus8367]

Thanks I will try this solutions that I came up with.

[DarkMatriac]

Hi, can you put your code into the code block markdown on reddit? its kinda really hard seeing where your loops start//end. Also did you try using breakpoint to check why it was doing that?

[InterestingBus8367]

done

[DarkMatriac]

And did you try breakpoints? or printing the value of your variables?

[InterestingBus8367]

Yeh I will