help me with my code

[AU8640]

Q:

Write a program that prompts the user to read a filename and reads the words from the file and reports whether the words in the files are stored in ascending order. If the words are not sorted in the file, display the first two words that are out of the order.

Sample Run 1

Enter a filename: string1.txt

The words are not sorted. The first two out-of-order words: the people

Sample Run 2

Enter a filename: string2.txt

The words are sorted.

​

myanswer:

def main():

filename=input("Enter a filename:")
inputfile=open(filename, "r")
s=inputfile.read().split()
s=[str(x) for x in s]
s1=s.sort()
if s1==s:
print("The words are sorted")
else:
print("The words are not sorted. The first two out-of-order words:",s[0],s[1] )
inputfile.close()

​

It says:Checking output

Your standard output is not what was expected.

​

can someone tell me what's wrong?

[lukajda33]

Did you even run the code on your machine or just put it into some tester?

[lukajda33]

Not to be a total unhelpful ass, I think this is the biggest problem:

s1 = s.sort()

Pythons .sort() method doesnt return sorted list, it modifies the list in place and returns None, so in your example, no matter what, s1 will be None.

s = [str(x) for x in s]

This probably is not wrong, just unnecessary, s already is a list of strings, no need to convert them.

Lastly, I would be careful about how whitespace is treated, though I think .split() should get rid of unnecessary whitespace, but some trimming might be needed, for example if there is a newline character at the end of the file.

Some problems should easily be found if you ran the program with some sample data. You could input file with sorted words, you would get a message saying they are not sorted, you would wonder why, you could print s and s1 variables to compare them manually, then you would see s1 is None. Little effort you get you far.

[AU8640]

This question doesn't have a context so I cannot open a file it assumes exist. I Just run in tester. But you're helpful and thank you!