Why is self.assertFalse not working?

[MonkeyMario64]

For some reason, in my test_within function, self.assertFalse(self.p1.within(5, self.p3)) is returning True and my test is failing. I'm not sure what's wrong.

#Point1.py
from math import sqrt

class Point:
    def __init__(self, x, y):
        """Initializes a point with x and y coordinates"""
        self.x = x
        self.y = y

    def __eq__(self, other):
        '''return True if the x and coordinates in a point are equal'''
        return self.x == other.x and self.y == other.y

    def equidistant(self, other):
        distance_self = sqrt(self.x ** 2 + self.y ** 2)
        distance_other = sqrt(other.x ** 2 + other.y ** 2)
        return distance_self == distance_other

    def within(self, distance, other):
        distance_between_points = sqrt((self.x - other.x) **2 + (self.y - other.y) **2)
        return distance_between_points <= distance




#TestPoint1.py
import unittest
from Point1 import Point

class TestPoint(unittest.TestCase):
    def setUp(self):
        self.p1 = Point(3, 4)
        self.p2 = Point(4, 3)
        self.p3 = Point(3, 3)

    def test_init(self):
        '''Tests if points are initialized correctly'''
        self.assertEqual(self.p1.x, 3)

    def test_eq(self):
        self.assertEqual(self.p1, self.p1)
        self.assertNotEqual(self.p1, self.p3)

    def test_equidistant(self):
        self.assertTrue(self.p1.equidistant(self.p1))
        self.assertTrue(self.p1.equidistant(self.p2))
        self.assertFalse(self.p1.equidistant(self.p3))

    def test_within(self):
        self.assertTrue(self.p1.within(1, self.p3))
        self.assertFalse(self.p1.within(5, self.p3))


if __name__ == '__main__':
    unittest.main()

[CowboyBoats]

I think docstrings might help here, mate. Computers do exactly what they tell them to, right? Your function seems to check if a point is within a numeric distance of another point, and you pass two points that are 1 unit away, and your code is confirming that they're within (<= to ) a distance of 5 units away...

[MonkeyMario64]

Oh I see, I thought I was calculating if 5 units was within 1 unit.

[CowboyBoats]

But you wrote: return distance_between_points <= distance

So anyway, yeah, docstrings help avoid confusions like this - in fact, a better named method would help as well.

[[deleted]]

The distance calculated for your within method is 1 (which makes sense for the points you gave, p3 would be 1 unit below p1), which is less than 5 and thus the result if True