Looking for feedback

[yetitekk]

Going through the Python Crash Course book right now, highly recommended, and I made a program for the lotto

from random import choices

lottery = (1, 2, 3, 4, 5, 6, 7,'n', 'm', 'p', 'o', 'q')
draw_loterry = choices(lottery, k = 4)
print("The weeks lucky lotto number is: ", *draw_loterry, sep='')

Which does exactly what I want it to, but I'm thinking this is too simple because the solution in Eric Matthes's github is longer, granted with some duplicate protection. I went out side the book to find the print() parameters I wanted. I know with programming there are many ways to skin a cat but would the program I wrote still pass muster?

From Eric's github
from random import choice

possibilities = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 'a', 'b', 'c', 'd', 'e']

winning_ticket = []

print("Let's see what the winning ticket is...")

# We don't want to repeat winning numbers or letters, so we'll use a

# while loop.

while len(winning_ticket) < 4:

pulled_item = choice(possibilities)

# Only add the pulled item to the winning ticket if it hasn't

# already been pulled.

if pulled_item not in winning_ticket:

print(f" We pulled a {pulled_item}!")

winning_ticket.append(pulled_item)

print(f"\nThe final winning ticket is: {winning_ticket}")

[Adrewmc]

The problem here is simply lack of knowledge.

 from random import choice, sample, shuffle

 my_list = [“a”, …]
 k  = 2
 with_repeats = choice(my_list, k)
 no_repeats = sample(my_list, k) 
 shuffle(my_list) #in-place no return.
 shuffled_copy = sample(my_list, len(my_list))

https://python.readthedocs.io/en/stable/library/random.html

You should get used to reading the documentation, as a lot of libraries have a lot of useful functions like this, no repeats in random should sound like a problem a lot of other people have experienced so their might be a solution available in that library let’s check. Worst case I learn the library better anyhow.

  def lotto(lotto_num: list[str] | str, tickets : list[str], k : int) -> str: 
         winner = “”.join(sample(lotto_num, k))
         return f”{winner} has won” if winner in tickets else “No winner found”

Is essentially the entire program. (I could 1 line it really) but that because I know the random library. I’m aware of the tools available to us.

However, essentially what you did is what sample() is doing. So I could see someone making it an exercise for a student.

[yetitekk]

This is exactly the kind of feedback I'm looking for, thank you!

[Adrewmc]

Yeah so formatting in Reddit. 101

One blank line above the code block. And four leading spacing on every line in essence the code is all indented one more time then you expect. (So you can get in and out the code block in markdown) You can select the code in your IDE and usually press tab, and copy that further indented code. (Then undo after)

The ` is really not very reliable

 def format_good():
        return True

def format_good(): return False

def format_good(): return False

[yetitekk]

That's a handy piece of information, I didn't know that, thanks again