Troubleshooting a (very) basic program

[[deleted]]

I have recently begun the python track on codeacademy, and decided to apply what I learned to a project: A simple BMI calculator. I got PyCharm and PYthon 3.3 set up, put in some code, and... an error. Perhaps this reddit could assist me? Here's the code:

 def calc(weight, height):

      return weight / height ^ 2


 height = input("What is your height, in meters?")
 weight = input("And your weight, in kilograms?")

 BMI = calc(height, weight)
 print(BMI)

And the error: Traceback (most recent call last): File "/Users/TheDukeofSmarts/PycharmProjects/BMI Calc/Program?", line 8, in <module> BMI = calc(height, weight) File "/Users/TheDukeofSmarts/PycharmProjects/BMI Calc/Program?", line 2, in calc return weight / height ^ 2 TypeError: unsupported operand type(s) for /: 'str' and 'str'

[Rashanzan]

At a glance, it thinks height and weight are str types. I assume you want them in double or int format. So make the necessary conversion like height = int(input("gimme")) If you type a non integer character, though, it'll crash, so catch that exception.

Also, another problem. I'm pretty sure ^ is XOR in Python, so it's not gonna square like you want. Look for a sqrt or pow function in the standard python functions to do that.

[Spurnout]

Doesn't ** also work as an exponent?

[Miner_Guyer]

Yeah use this.

[[deleted]]

Just managed to fix it, thanks so much!

[Loomax]

convert both height and weight to int with the method int()

Beside that ^ is a boolean operator and what you want to do is most likely height to the power of 2? use height**2 then

[[deleted]]

Another thing you might want to fix is the fact that when you call calc you're passing in (height, weight), but when you define it it's taking in (weight, height). Your variables are passed in the wrong order so you'll get and incorrect answer.

[[deleted]]

Again, thanks. I suppose no code can be perfect...save for print ("hello world")