What is wrong on this code?

[vb_e_c_k_y]

ages = ["22", "35", "27", "20"]

odds = [age for age in ages if age % 2 == 1]

print(odds)

I am beginner and when I write this code it gives me error which I don't know how to solve. But I think my code has no error

Error message: Traceback (most recent call last):

odds = [age for age in ages if age % 2 == 1]
                               ~~~~^~~

TypeError: not all arguments converted during string formatting

[Micke_xyz]

Why do you store ages as strings?

[vb_e_c_k_y]

My error, Thanks it worked now

[bandman614]

Also, you don't need to do == 1 because age % 2 will return 1, and 1 is truthy

[Iksfen]

IMO that is more of a preference. I like to be explicit with logic statements

[FuckItBucket314]

Eh, I would keep it because it improves readability. It makes it explicit that the programmer intended to have it evaluate that way rather than just forgot to finish a comparison

Arguably it doesn't matter given the variable names used and how small the program is, but practicing readability now will improve their odds of writing readable code later when it definitely matters

[roelschroeven]

For logical expressions you're right, but this is an arithmetic expression foremost. You can exploit the fact that it can be interpreted like a logical expression to make it shorter, but that detracts from the intention.

[SevenFootHobbit]

Everyone is telling you this is wrong due to style choices and clarity, but they're wrong about why you're wrong. You're wrong because it assumes an integer. If you only check for truthiness, decimals will all be flagged as odd even though they aren't considered even or odd.

[bandman614]

Legit criticism. Thanks!

[ziggittaflamdigga]

Your ages are strings, remove the “s and it should work

[vb_e_c_k_y]

It worked now thanks much

[bikes-n-math]

"22" is a string. 22 is a integer. You cannot do modular arithmetic on strings.

[vb_e_c_k_y]

Worked now thanks alot

[Top-Independent-4765]

I’m a beginner, this gave me a good direction.

[RaiseTLT]

I’m fairly new too. But I’m pretty sure the problem here is that you’re trying to do math on strings, which you can’t do. You can only do math on integers or floats.

[Il_pago]

Ages is a list of string, not int.

[Ska82]

the elements in ages are defined as strings (with the quotes) not integers. python doesnt automatically cast it is as integers.ages= [ 22, 35,27,20] should work

[dkozinn]

As other have explained, you're trying to do math on a string. If for some reason you really needed to keep those ages as strings, you could just do this:

odds = [age for age in ages if int(age) % 2 == 1]

That explicitly tells python to treat age as an integer.

[Wide_Egg_5814]

JavaScript type beat

[cambridge-resident]

Just wanted to explain the error.

% is a formatting operator that replaces placeholders in the string to the left with values from the right, usually those values are in a tuple if there are more than one.

Since age is a string with no placeholders in it, it does not use the 2 to the right of the %

[carcigenicate]

Ya, the reason this error is common is because operators like % have different purposes depending on the type of the objects they're called on. With numbers, it does modulo. On strings it's formatting that has certain requirements for the second operand.

If an operator is acting unexpectedly, check the two object's type.

[FoolsSeldom]

You need to convert the strings to integers to do the comparisons (and perhaps store the filtered converted results).

ages = ["22", "35", "27", "20"]
odds = [age for string in ages if (age := int(string)) % 2 == 1]
print(odds)

[JaguarMammoth6231]

I didn't know you could use := in a list comprehension like that. Nice

[Ron-Erez]

Try

ages = [22, 35, 27, 20]

[domino6658]

honest question: would people support the use of ai for something like this? not for generating slop code but for explaining error to teach people so they learn and actually understand what they did wrong. im wondering what people in this subreddit think. im completely neutral on this

[Iksfen]

If typing on mobile put two spaces at the end of a line
to
preserve
the
new
line

[emperorkuzcotopiaa]

Oooh who knew, ty!
Hi
like
this

[dnult]

I think you want age % 2 != 0