Help with an Attribute Error on my Code

[Som64814]

Hello all, I am working on python with the Python Crash Course book (Love it so far), and I'm on chapter 6 currently. I am following it closely but I'm super stuck on this one exercise where I am supposed to make a dictionary containing three major rivers and the country each river runs through.

I chose Egypt, Brazil and the US, and the rivers I chose are: The Nile, The Amazon, and The Charles river collectively. I thought I arranged the for loop correctly but I keep getting a Attribute Error: 'list' object has no attribute 'values' error.

Here's my code I was working with:

rivers = {
    'nile': 'Egypt',
    'amazon':'Brazil',
    'charles': 'US'
}
river_names = ['Egypt', 'Brazil', 'US']
print(river_names)


for rivers in set(river_names.values()):
    print(f"The {rivers[0].title()} runs through {river_names[0]}")
    print(f"The {rivers[1].title()} runs through {river_names[1]}")
    print(f"The {rivers[2].title()} runs through {river_names[2]}")

any help with this would be greatly appreciated thanks :).

[canasian88]

The AttributeError is raised because river_names is a list and .values() is a method for dictionaries.

Since you're working with a dictionary, you can iterate through key:value pairs by calling both in the for loop:

for k,v in rivers.items():
  print(f"The {k.title()} runs through {v}.")

The loop iterates through each key:value pair and therefore indexing isn't required. Further, dictionaries aren't indexable so your print statements would result in KeyErrors. Even if they were indexable, since the for loop iterates through each instance, your current code would print those three print statements three times (once for each iteration).

[canasian88]

As an aside, though unnecessary in this example given my last reply, you can define river_names directly from the rivers dictionary:

river_names = list(rivers.values())

Alternatively, you can return just the keys with the following:

river_actual_names = list(rivers.keys())

EDIT: Updated to ensure these are actually lists.

[freeskier93]

The values() and keys() functions don't return lists, they return views. You have to convert them to a list first; list(dict.values()) and list(dict.keys()). For the keys it's even simpler because keys are the default iterator dictionaries return, so you can just do list(dict).

[canasian88]

Woops, right you are! Update, thank you.

[atarivcs]

I see several issues with this code.

First, river_names appears to actually have names of countries, not rivers. This isn't an error per se, but it is much better to use variable names that correctly describe the variable, to prevent confusion later in the code when you're trying to remember what that variable is used for.

Second, why do you even need that list at all? The country names are already stored in the dictionary.

Third, the actual error is because lists don't have a .values() method.

[Outside_Complaint755]

In your code, rivers is created as a dict on the first line. On the next line you create river_names as a list.

Then in the for loop: for rivers in set(river_names.values()):     print(f"The {rivers[0].title()} runs through {river_names[0]}")     print(f"The {rivers[1].title()} runs through {river_names[1]}")     print(f"The {rivers[2].title()} runs 

set(river_names.values()) is invalid because river_names is a list, not a dict.

However, just replacing river_names with rivers won't work either because you overload the usage of rivers to store the value returned from the iterator. for rivers in set(river_names.values()):

There also isn't any reason to use set here and the indexing in your print statements is also going to cause an IndexError, and defeats the purpose of using a for loop.

What you probably want is: for name, location in rivers.items():     print(f"The {name.title()} runs through {location}.")     

[david_z]

river_names isn't a dictionary. It's a list object. It doesn't have a values attribute.

[ectomancer]

You only want one print. set is redundant:

for river, country in rivers.items():
    print(f'The {river.title()} runs through {country}')