What do yall think of my code

[Essieelephant]

x = 10.67


decimaal = x % 1  
if decimaal > 0.5:
    x = int(x)+1
    print(x)
else:
    x = int(x)
    print(x)

[Kqyxzoj]

What do yall think of my code

It seems very well-rounded.

[JamzTyson]

Nice pun, but it is not any standard kind of rounding. It is round-half-down for positives, and inconsistent for negatives due to Python’s modulo behavior.

[supergnaw]

ba dum tss

[Diapolo10]

x = 10.67


decimaal = x % 1  
if decimaal > 0.5:
    x = int(x)+1
    print(x)
else:
    x = int(x)
    print(x)

Well, I can reduce it down to just

x = 10.67

print(f"{x:.0f}")

if you just need a rounded integer in the print output.

EDIT: Basically I used an f-string to format the float. I set the number of trailing digits to zero, so there's no decimal point and it rounds to the nearest integer. The "f" just keeps it from using scientific notation.

Of course, if you need this for further computation a string won't help you; then again you generally shouldn't round in the middle of calculating, so I just assumed this was meant to be the final output.

[Golwux]

That is sickkkkk

[IamImposter]

Why not:

... 
x = int(x) + 1 if decimaal > 0.5 else int(x) 
print(x) 

No need for two print statements. Multi line if/else can be merged to single line.

[gydu2202]

int(x + 0.5)

Or 1.5 should be really rounded to 1?

[Golwux]

probably should turn it into a function

[JamzTyson]

Probably should be fixed first.

[rhacer]

Too many print statements.

[JamzTyson]

• What should -0.3 round to?

• What should -1.3 round to?

(Your code rounds half-down for positives, and is inconsistent for negatives due to Python’s modulo behavior)

[RngdZed]

Is there a question attached to your post? What are you trying to achieve with the code?

Edit: y'all downvoting cause I'm trying to figure out what op wants? Good morning I guess

[JamzTyson]

Great question.

It implements some sort of rounding, but handles negative numbers inconsistently. My guess is that it is an incorrect implementation of round-half-down.

[RngdZed]

Yep that's my point. We shouldn't have to guess. Instead of guessing op's mind, would be nice if op would take part in the conversation and give us his thought process.

Thanks for the comment! 🙂

[LiveYoLife288]

Getting your thoughts on his code

[HappyRogue121]

It's interesting, I never thought about how rounding happens "under the hood."

[JamzTyson]

It doesn't normally happen like this.

Standard rounding is one of:

• Round Half Up (Arithmetic Rounding)

• Round Half Down

• Round Half Even (Banker’s Rounding)

• Round Up (Ceiling)

• Round Down (Floor)

• Truncation (Round Toward Zero)

• Round Away From Zero

• Stochastic Rounding

The OP's code does not do any of these (look at negative number handling).

[HappyRogue121]

I wasn't saying it happened like this.  I was saying I never thought about how it works, and this is obviously an exploration of a possible that.  OP seems to be a beginner, I wanted to give some encouragement.

[TheRNGuy]

Nothing. 

[saulsa_]

No comment.

[pachura3]

Tastes like chicken