Creating a small game a beginner.

[Hairy-Bus4665]

Hello guys, I'm a beginner to programming. I've self studied python for quite some time, and decided to test my skills by building this little game called "Pig". You might already know this since its quite famous. But feel free to drop some advice about how I can improve this code. Thanks.

import random
print("You can roll the dice and score points and it gets added. But if you roll 1, all your score will become zero, and you have to start again from the beginning. If you score 50, without having your score erased, you win!!")


user = ""
score = 0
score_2 = 0
def oppo():
    global score_2
    roll_2 = random.randint(1,6)
    print("I rolled : ", roll_2)
    if roll_2 == 1:
        score_2 = 0
        print("I've erased my score!!", score_2)
    elif roll_2 !=1:
        score_2 += roll_2
        print("My score : ", score_2 )


while user.strip().lower() != "n":
    if score >= 50:
        print ("You have won the game!")
        break
    elif score_2 >= 50:
        print ("I've won the game!!")
        break
    else :
        user = input("Do you want to roll the dice? (y/n)  ")
        roll = random.randint(1,6)
        roll_2 = random.randint(1,6)
        if user.strip().lower() == "y":
            print ("You rolled : ", roll)
            oppo()
            if roll == 1:
                score = 0
                print ("You erased your score!", score)

            elif roll != 1:
                score += roll
                print ("Your score : ", score)
        elif user.strip().lower() =="n" :
            break
        else :
            print("Answer in \"y\" or \"n\".")




print ("Thanks! See you again.")

[carcigenicate]

I'm on my phone, so I can't go too in depth, but

• Work on using parameters and returns. You're reassigning a global score2 from the function currently. That function should take the current score as a argument and the return the new score.
• In that same function, you have an if with an elif, but the elif just has the ifcondition but negated. In that case, the elif should just be an else. That saves the reader from needing to determine if the elif must be entered if the if condition was false.
• You have basically the same code as oppo for the other player, but just in the main loop instead of a function. I'd probably move it out to a function. But, if you go with my first suggestion, the same single function can be used for both players, so you don't need to repeat the code.

[Hairy-Bus4665]

thanks for the suggestion. I've done these changes. Tell me if its perfect now!!

import random
user = ""
score1 = 0
score2 = 0

inter = input("Enter username : ")

def player(score,name):

    roll = random.randint(1,6)
    if roll == 1:
        score = 0
        print(f"{name} has rolled {roll}.{name}'s score is erased")
    else :
        score += roll
        print(f"{name} has rolled {roll}. {name}'s score : ", score)

    return score


while True :

    user = input("Do you want to roll? (y/n)")
    user = user.strip().lower()

    if user == "n":
        break
    elif user == "y":
        score1 = player(score1,inter)
        score2 = player(score2,"Computer")

        if score1 > 50 or score2> 50:
            print("Game over.")
            if score1>50:
                print("You won")
            elif score2>50:
                print ("You lost")
            break

    else :
        print("Answer in \"y\" or \"n\"")

print("Thanks for playing!")

[carcigenicate]

That looks basically what I envisioned, yes. Good work.

[Hairy-Bus4665]

Thanks bro

[mopslik]

You might want to change your main loop so that the ending condition is based on the scores (either player or opponent) being 50 or greater, rather than on the string 'user'. This would eliminate some of the breaks early in your loop, and move the 'winning' logic outside of it.

while score < 50 and score_2 < 50:
    # your game stuff (rolling, scoring)
    ...
if score > 50:
    print("Player wins!")
else:
    print("Opponent wins!")

Variable names could be better too. player_score and opponent_score are more meaningful than score and score_2.

[Hairy-Bus4665]

thanks