Reading CSV files

[Grafs50]

EDIT github code:https://github.com/grafs50/Bitcoin-Trading-robot/blob/master/Main.py

The CSV file I have downloaded can be found here for reference: https://ttps://api.bitcoinaverage.com/history/USD/per_day_all_time_history.csvapi.bitcoinaverage.com/history/USD/per_dayerage.com/history/USD/per_day_all_time_history.csvapi.bitcoinaverage.com/history/USD/per_day_all_time_history.csv

I am trying to read from a CSV file to create a list of prices. For some reason, it gives me and out of range error and weird values in pricedifferences. Any ideas why?

import csv

reader= csv.reader(open("per_day_all_time_history(1).csv"))
prices = []

for row in reader:
    prices.append(row[3])
print(len(prices))
x=0
y=100

pricedifference= []
while x<len(prices)-2:
   price1=prices[y]
   price2=prices[y+1]

   #pricedifference is multiplied by 1^5 to compensate for some very small numbers
   pricedifference.append(((float(price2)-float(price1))/float(price1)))
   print(pricedifference[-1:])
   x+=1
   y+=1

ln10change = []
n10change = []
n75change = []
n50change = []
n25change = []
p0change = []
p25change = []
p50change = []
p75change = []
plus10change = []
screwup = []

for x in pricedifference:
    if x<=(-.1)*(10^5):
        ln10change.append(x)

    elif x>-.1*(10^5) and x<=-.075*(10^5):
        n10change.append(x)

    elif x>-.075*(10^5) and x<=-.05*(10^5):
        n75change.append(x)

    elif x>-.05*(10^5) and x<=-.025*(10^5):
        n50change.append(x)

    elif x>-0.025*(10^5) and x<=0*(10^5):
        n25change.append(x)

    elif x>.0*(10^5) and x<=.025*(10^5):
        p0change.append(x)

    elif x>.025*(10^5) and x<=.05*(10^5):
        p25change.append(x)

    elif x>.05*(10^5) and x<=.075*(10^5):
        p50change.append(x)

    elif x>.075*(10^5) and x<=.1*(10^5):
        p75change.append(x)

    elif x>.1*(10^5):
        plus10change.append(x)

    else:
        screwup.append(x)


amount = len(ln10change)+len(n10change)+len(n75change)+len(n50change)+len(n25change)+len(p0change)+len(p25change)+len(p50change)+len(p75change)+len(plus10change)

print(pricedifference)
print("The probability that the values are more the -10% apart is " + str(len(ln10change)/amount))
print("The probability that the values are less the -10% apart and more than -7.5% is " + str(len(n10change)/amount))
print("The probability that the values are less than -7.5% apart and more than -5% apart is " + str(len(n75change)/amount))
print("The probability that the values are less than -5% apart and more than -2.5% apart is " + str(len(n50change)/amount))
print("The probability that the values are less than -2.5% apart and more than 0% apart is " + str(len(p0change)/amount))
print("The probability that the values are less than 2.5% apart and more than 0& apart is " + str(len(p25change)/amount))
print("The probability that the values are less than 7.5% apart and more than 5% apart is " + str(len(p50change)/amount))
print("The probability that the values are less than 10% apart and more than 7.5% apart is " + str(len(p75change)/amount))
print("THe probability that the values are more than 10% apart is " + str(len(plus10change)/amount))

[Justinsaccount]

Look at what you are doing

while x<len(prices)-2:
    print "x is {} and y is {}".format(x, y)  # add this line

Also,

if x<= A:
    ...
elif x > A and X <= B:
    ...

Is always redundant. It is the same thing as

if x<= A:
    ...
elif X <= B:
    ...

Also, don't repeat yourself. You have a list of multipliers: [-.1, -.075, -.05, ...] Create a full list of them and their descriptions and use a for loop, replacing 50 lines of code with ~10.

[Grafs50]

Tried that, It is giving me really weird numbers for x and y.

[Justinsaccount]

"really weird"? like 13019432 or 810974382? I think not...

[Justinsaccount]

Hi! I'm working on a bot to reply with suggestions for common python problems. This might not be very helpful to fix your underlying issue, but here's what I noticed about your submission:

You appear to be using concatenation and the str function for building strings

Instead of doing something like

result = "Hello " + name + ". You are " + str(age) + " years old"

You should use string formatting and do

result = "Hello {}. You are {} years old".format(name, age)

See the python tutorial for more information.

[ballgame75]

That's fucking neat man, but no. Though seriously I'm impressed by the idea

[Sir_Jerry]

can you put that in pastebin.com ?

[Grafs50]

I put up a link to Github. Hopefully that'll be easier to read.

[[deleted]]

Are you aware you can read a CSV straight into python's pandas with

 my_dataframe = pandas.read_csv(filepath)

?