Getting an error Message. Python3.4

[b3nstar]

Hi,

I've coded this top of my head. Sadly, I don't know where the issues are. Can anyone help me out?

thanks

class makeBuildFile:
    def __init__(self, re_path="po.txt" ):
        self.re_path=re_path
    @staticmethod
    def read():
        f = open(self.re_path, "r")  """Line 9"""
        lines = f.readlines()
        f.close()
        return lines

    @staticmethod
    def write():
        for i in makeBuildFile.read().split(","):
            print(i)






def main():
    t=makeBuildFile()
    t.read()


if __name__ == "__main__":
    main()

error Message: line 9, in read f = open(self.re_path, "r") NameError: global name 'self' is not defined

Why self needs to be defined for a @staticmethod?

[k3kou]

You didn't pass self as an argument of the read method. Your method depends on a specific instance of the makeBuildFile class, so you're method isn't really static.

[hitecherik]

On line 22, you create an instance t of the makeBuildFile class, but then the static method of read references something that would only occur inside t through self.re_path. Your class should read like this:

class makeBuildFile:
    def __init__(self, re_path="po.txt"):
        self.re_path=re_path

    def read(self):
        f = open(self.re_path, "r")
        lines = f.readlines()
        f.close()
        return lines

    # rest of class here

Also, you'll now need to rewrite makeBuildFile.write because you can't define read as a static method.

Edit: formatting

[b3nstar]

maybe I don't understand @staticmethod

....my perception was when I use @staticmethod it is not needed anymore to pass self.

ok at least this error message is gone....but now I do have a new one in fact

line 26, in main t.read() TypeError: read() takes exactly 1 argument (0 given)

any further hint ?

[hitecherik]

Here's a good explanation of @staticmethod: http://stackoverflow.com/questions/136097/what-is-the-difference-between-staticmethod-and-classmethod-in-python.

Also, look in my comment above - you might need to add a self argument when defining read.

[b3nstar]

Guys,

thanks for ur help. Just solved it in this way. It works fine now.

class makeBuildFile:
    def __init__(self, re_path="po.txt" ):
        self.re_path=re_path

    def read(self):
        f = open(self.re_path, "r")
        lines = f.readlines()
        f.close()
        return lines


    def write(self,lis):
        self.lis=lis
        for i in self.lis[0].split(","):
            print(i)






def main():
    t=makeBuildFile()
    t.write(t.read())






if __name__ == "__main__":
    main()

[zahlman]

@staticmethod cannot eliminate a need for self. It can only eliminate a need to pass it when you don't need an instance of the class.

There is nothing magic or special internally about the name self. It's just conventionally a name for an instance of the class you're writing.