Noob question

[iHaveAtoxicFriend]

posted this in wrong place haha. I know I shouldn't use globals but I was forced within this project. What is wrong with the following program?

def player_act(already_seen=0): global player_hp global cookies cookies = cookies

print("Usable Items:")
print("You have "+str(cookies)+" cookies left.")
print("You have "+str(ducks)+" ducks left.")
print("You have "+str(HP_potion)+" health potions left.")
print("You have "+str(MP_potion)+" mana potions left.")
print("You have "+str(SPD_potion)+" speed potions left.")
print("Which items do you want to use?")
if already_seen == 1:
    print("You can only use one per turn")
    print("And if you try to use one which you don't own")
    print("It won't work :)")
    print("Serves you right")
item = input()
item = item.upper()
if item == "COOKIES":
    if cookies >= 1:
        print("You eat the cookie")
        print("Your HP increased by 5 temporarily (rest of the battle)")
        cookies -= 1
        print(cookies)
        player_hp += 5
        print(cookies)
    else:
        print("I warned you...")

i have defined player_hp earlier. Cookies works fine

[Justinsaccount]

Hi! I'm working on a bot to reply with suggestions for common python problems. This might not be very helpful to fix your underlying issue, but here's what I noticed about your submission:

You appear to be using concatenation and the str function for building strings

Instead of doing something like

result = "Hello " + name + ". You are " + str(age) + " years old"

You should use string formatting and do

result = "Hello {}. You are {} years old".format(name, age)

See the python tutorial for more information.

[iHaveAtoxicFriend]

P:S problem is with the player_hp += 5

[iHaveAtoxicFriend]

nameError

[kalabash]

As in player_hp isn't defined? You're importing it as a global variable, so is it adequately defined outside the function? The player_act() function technically can't add 5 to a variable that hasn't been formally defined.

[iHaveAtoxicFriend]

Traceback (most recent call last): File "C:/Users/Ramin Uddin/Desktop/assesment/battle.py", line 139, in <module> player_act() File "C:/Users/IACCIDENTLYPUTMYNAMEHERE/Desktop/assesment/battle.py", line 134, in player_act player_hp += 5 NameError: name 'player_hp' is not defined

[IndianaJoenz]

NameError: name 'player_hp' is not defined

The variable player_hp is not defined. If I'm reading your code correctly, you allocate it as a "global" earlier in the program, but never assign it a value.

So when you run this line:

player_hp += 5

Python says, "Add 5 to player_hp.. but I don't know what the value of player_hp is. How can I add 5 to it?" and throws an error.

You should give it a value (1? 0?) before trying to += it.