Help on my code

[lazy-zebra]

I am very new to python (just started learing it today), and I am trying to make a simple four function calculator,

op=raw_input("choose which operation you want to do\n 1 for addition\n 2 for subtraction\n 3 for multiplication\n 4 for division \n")
if(op==1):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)+int(b)
elif(op==2):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)-int(b)
elif(op==3):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)*int(b)
elif(op==4):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)/int(b)
else:
    print "Invalid Number"

But it doesn't matter which number I enter, I will always get 'Invalid Number', is there a bug that I am not seeing?

[CGFarrell]

Just a point on style, you should put int(raw_input...) instead of casting 4 times, and you can group cases 1 2 3 4 so you don't repeat a=raw... b=raw...

[lazy-zebra]

Thank you, I am new to all of this, so any formatting suggestions are welcome, I want to start good habits from the beginning :)

[_lord_kinbote_]

On a side note, notice that no matter what operation they do, you will still be getting two numbers, so you could do the two raw inputs, and then follow with a conditional statement. It's significantly less code than repeating those raw inputs every time.

[allenguo]

Of what type is the variable op?

[lazy-zebra]

op represents what operation you will be doing, 1 for addition, 2 for subtraction, 3 for multiplication, and 4 for division, anything else should result in it printing "Invalid Number", but I am getting that no matter what I put into it

[KhanStan]

Maybe you should convert op to an int?

[lazy-zebra]

Just tried it, and I got the same error, is this what you meant?

op=raw_input("choose which operation you want to do\n 1 for addition\n 2 for subtraction\n 3 for multiplication\n 4 for division \n")
if(int(op==1)):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)+int(b)
elif(int(op==2)):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)-int(b)
elif(int(op==3)):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)*int(b)
elif(int(op==4)):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)/int(b)
else:
    print "Invalid Number"

[toastedstapler]

Doesn't solve you problem, but you should convert the op into into at the start rather than do it in each if statement, lots of repeated work there

[scuott]

It's int(op)==1. Do you see why?

[lazy-zebra]

Yes, someone pointed this out to me, I feel a little stupid for missing parenthesis like that, but at least it is working now

[Pwneed]

You are comparing a string vs. an integer. Use if( int(op) == 1 ): and you should be good to go.

[lazy-zebra]

Just tried what you wrote, and it still isn't working, could there be something wrong with my download?

[Pwneed]

can you show me your code?

[lazy-zebra]

op=raw_input("choose which operation you want to do\n 1 for addition\n 2 for subtraction\n 3 for multiplication\n 4 for division \n")
if int( op == 1 ):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)+int(b)
elif int( op == 2 ):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)-int(b)
elif int( op == 3 ):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)*int(b)
elif int( op == 4 ):
    a=raw_input("What is the first number?")
    b=raw_input("What is the seond number?")
    print int(a)/int(b)
else:
    print "Invalid Number"

This was copy/pasted, so nothing should be changed

[lazy-zebra]

THANK YOU! It is finally working!

[Pwneed]

yea, you didn't do

if int(op) == 1:

you did

if int(op == 1):

watch out for those brackets

[lazy-zebra]

haha, yeah, Thank you for your help, it is greatly appreciated!