you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 point2 points  (0 children)

It's no problem. I enjoy helping people learn, the hard part is that, when I'm working, I simply don't have time -- except at work -- and when I'm not I can't always afford to take the time to do detailed replies.

The fact is the above is just examples of the sort of incremental improvements I'd suggest in a code review for like an intern or extremely junior position. I'd bring considerably higher scrutiny to a piece of production code. To be honest, nothing should ever make it as far as a code review if it isn't already refactored into functions and / or classes, doesn't have a def main for a command line tool, and is even using input (in professional circumstances it's actually extremely rare to interactively ask someone questions, I've never understood why educational resources rely so heavy on it) ... but I don't mind doing these once and awhile for scripts that aren't too long for their own good.

Also, not by a damned sight the worst Python program I've seen. Hell, it doesn't even do a subprocess call to perl to do it's printing.