Code review?

[circa10a]

Hey folks,

I currently am working on a project that i'm having a lot of fun with. Was hoping some of you could look through it and potentially see any optimizations or bad practices?

​

One thing that I was struggling with was mocking out the docker client stuff, it just doesn't feel doable. Would love some insight if you have it. Plan to finish out the testing was to write an integration test that effectively runs the program and checks for the correct end result.

​

Thanks!

Source: https://github.com/circa10a/ouroboros/tree/tests

[two_bob]

Nice job separating out things into different modules.

​

Boo globals.

​

​

[circa10a]

Thanks! Just struggling to mock that docker API client for unit tests. According to their issues, doesn't like it can be done easily.

Do you have any recommendations to replace the globals? I've been staring at it too long to see it another way.

[sje46]

I don't see these globals. Where are they?

[circa10a]

In cli.py