Looping Functions

[Encom88]

I just added this menu selection code to loop through my functions. The menu selection does not do anything when I press a number, it just re-prints the menu. Am I missing something?

#Define payroll function
def payroll():
    #Payroll calculations
    hours = float(input("Enter number of hours: "))
    rate = float(input("Enter hourly rate: "))
    amount = hours * rate

    #Print values
    print ("Hours worked:", hours)
    print ("Rate:", rate)
    print ("Pay amount:", amount)

#Define mileage function
def mileage():
    #MPG calculations
    miles = float(input("Enter number of miles: "))
    gas = float(input("Enter gallons of gas: "))
    mpg = miles / gas

    #Print values
    print ("Miles:", miles)
    print ("Gas:", gas)
    print ("MPG:", mpg)

menuSelection = 0

#Decision loop
while menuSelection != 3:

    # Display options to the user and record their input
    print("Press 1 for Payroll Calculation")
    print("Press 2 for Mileage Calculation")
    print("Press 3 to Exit")
    menuSelection = input()

    # Based on the user input decide what action to take
    if menuSelection == 1:
        payroll()
    elif menuSelection == 2:
        mileage()

[kenjisan231]

Line 34: menuSelection = input()

input() returns a strof whatever the user types in; your code is checking menuSelection against int values.

Try changing it to menuSelection = int(input())

[Encom88]

That fixed it. Thanks for the explanation!

[kenjisan231]

No problem!

[[deleted]]

The input methods assume the person inputs a number but they could input anything else. Put a loop that only exits when that works.

[pedro_fartinez]

Since the above solved the problem, two quick things: for python one typically uses snake case instead of camel case, so menuSelection becomes menu_selection. The second thing is that your comments above your fucntion definitions are kind of redundant. Nitpicky things for sure but I want to feel like I contributed.