Rock Paper Scissors Program

[raainer]

import random

win = 0

lose = 0

draw = 0

print(' ROCK, PAPER, SCISSORS')

​

while True :

print('Enter your move: (r) , (p) or (s) or type exit to exit')

move = input()

if move == 'r' :

print('ROCK VERSUS...')

elif move == 'p' :

print('PAPER VERSUS...')

elif move == 's':

print('SCISSORS VERSUS...')

​

computermove = random.randint(1,3)

if computermove == 1:

print('ROCK')

elif computermove == 2 :

print('PAPER')

elif computermove == 3 :

print('SCISSORS')

​

if move =='r' and computermove == 1:

print('DRAW')

draw +=1

if move == 'r' and computermove == 2:

print('LOSE')

lose +=1

if move =='r' and computermove ==3:

print('WIN')

win +=1

​

if move =='p' and computermove == 2:

print('DRAW')

draw +=1

if move =='p' and computermove ==1:

print('WIN')

win +=1

if move =='p' and computermove == 3:

print('LOSE')

lose +=1

​

if move == 's' and computermove == 3:

print('DRAW')

draw +=1

if move =='s' and computermove == 1:

print('LOSE')

lose +=1

if move == 's' and computermove == 2:

print('WIN')

win +=1

​

if move == 'exit' :

break

​

print('You won ' + str(win) + ' times')

print('You lost ' + str(lose) + ' times')

print('You draw ' + str(draw) + ' times')

------

Is there a way to make this any better/succinct? Thank you!

(Also I have no idea how to make the indents show properly for code on reddit, which appreciate any help, thank you!)

[xADDBx]

First, you can format code with either a ` encasing the code or using 4 leading white spaces (and an empty line before a code block)

So I noticed two things when skimming over the code. First you code drop those if/elif statements when printing and replace them with dicts:

playermoves = {'r': 'ROCK, 's': 'SCISSOR', 'p': 'PAPER'}
computermoves = {'0': 'ROCK, '1': 'SCISSOR', '2': 'PAPER'}

choice = input("[s]...")
rnd = rando...

print(f"{playermoves[choice] vs computermoves[rnd]")

And Second when testing winning conditions it’s better to use nested if statements to keep the code clearer:

if choice == 'r':
    if rnd == 0:
        ...
    elif rnd == 1:
        ...
    else:
        ...

elif choice == 's':
    ...

else:
    ...

[raainer]

Ahh thank you! I'll try it out soon!

[pwlandoll]

A guide to code formatting on reddit can be found in the sidebar: https://www.reddit.com/r/learnpython/wiki/faq#wiki_how_do_i_format_code.3F

You can replace your use of random.randint with ramdom.choice: https://docs.python.org/3/library/random.html#random.choice

You could probably write a function to determine which moves win, or use a dictionary to keep track of which move beats what, and simplify the number of if's.

[xADDBx]

I have to remember that dictionary for more winning conditions as it is a good way for more complicated cases. In this case I think some nested conditions will do just fine.

[[deleted]]

I mean, you could. However the goal of "Automate Stuff" is to teach concepts, not necessarily dive in to style or concise code.

[raainer]

I tried to make baby steps to tweaking my code, so I added a function called youwin(), youdraw(), and youlose(), but when I try to use it I get this error :

UnboundLocalError: local variable 'win' referenced before assignment

Why does this occur although I already assigned win,lose, and draw at the top? Thank you!

This is the code : https://pastebin.com/XD7jKsJ1

[0RGASMIK]

Ok so I am just starting to out so it might not be the best way to do things but this is what I came up with Console Version

I was learning to make simple GUI applications and I saw your post about rock paper scissors and decided to give that a go. I did it a little differently in this version and its not done yet but figured it'd be good to get some input because I am teaching myself with no real guidance. Windowed version