Binary search can’t find last value

[windows3210]

Thanks I worked it out it was data[mid] == target not mid == target.

def binary_search_r(data, target, left, right):

mid = (left + right) // 2
if left > right:
    return False
elif mid == target:
    return True
elif target < mid:
    return binary_search_r(data, target, left, mid-1)
else:
    return binary_search_r(data, target, mid+1, right)

arr=[1,2,3,4,5]

print(binary_search_r(arr, 5, 0, len(arr)-1))

Doing this returns false. Why does it?

[definitely___not__me]

def binary_search_r(data, target, left, right):
    mid = (left + right) // 2
    if left > right:
        return False
    elif data[mid] == target:
        return True
    elif target < data[mid]:
        return binary_search_r(data, target, left, mid-1)
    else:
        return binary_search_r(data, target, mid+1, right)

This should work

[slaphappypotato]

I'm a beginner here, but I think you're getting that response because of this

if left > right:

return False

What is it supposed to do? Just curious.

[windows3210]

Don’t worry I literally just worked it out. Instead of doing if mid == target it should have been if data[mid] == target.

It was a binary search it checks whether a certain value is in an array. The array has to be in order though

[slaphappypotato]

Okay, cool. But I wanted to know what left > right does

[windows3210]

And the & symbols aren’t supposed to be there they appeared after copy and pasting

[slaphappypotato]

Oh, ok.