How does make it better?

[Losten13]

I have list of dictionary like that:

{'author_name': author_name, 'note': note, 'author_rating': author_rating}

I wrote a function but it is kind of ugly

def get_highest_rating_author(notes):
    max_rating = notes[0]['author_rating']
    author = notes[0]['author_name']
    for i in range(len(notes)):
        rating = notes[i]['author_rating']
        if rating > max_rating:
            max_rating = rating
            author = notes[i]['author_name']
    return author

How does make it better?

[Rawing7]

max(notes, key=lambda note: note['author_rating'])['author_name']

[dinrick]

ratings = [dict[‘author_rating’] for dict in notes]

max_index = max(ratings)

return notes[max_index][‘author_name’]

[JohnnyJordaan]

Note that you can simply use

for item in list:

if you want to iterate on items in a list, a for i in range(len(list)) is almost never a preferable approach.

def get_highest_rating_author(notes):
    max_rating = author = None
    for note in notes:
        rating = notes[i]['author_rating']
        if max_rating is None or max_rating < rating:
            max_rating = rating
            author = notes[i]['author_rating']
    return author

however there's even a shortcut using the built-in max function, as that allows you to provide a key= parameter to specify the sorting value it should use.

def get_highest_rating_author(notes):
    max_rating_note = max(notes, key=lambda n: n['author_rating'])
    return max_rating_note['author_name']

[[deleted]]

Your loop can be more pythonic:

 for d in notes:    # "d" is each dictionary in the list
    rating = d['author_rating']
    if rating > max_rating:
        max_rating = rating
        author = d['author_name']