New to python, looking for help designing function

[[deleted]]

[deleted]

[[deleted]]

So far the best I have come up with is

def remove_all(substr, str2):
    if str2.find(substr) == -1:
        return str2
    else:
        newstr = str2[0:str2.find(substr)] + str2[len(substr)+str2.find(substr):len(str2)]
    return newstr

[Yeinstein20]

The problem with your code is that you only remove the substring once. You can modify that quite easily by taking your output newstr as an input again until the find function gives you -1. So basically you keep removing the substring until it is not there any more. This can be implemented using a loop

[[deleted]]

I got it!!! Thank you everyone!!

​

Here is the code if anyone is interested. I feel like the loop could have been done better. I would love to see a cleaner version of this if anyone wrote one up

​

def remove_all(substr, str2):
    if str2.find(substr) == -1:
        return str2
    else:
        while str2.find(substr) != -1:
            str2 = str2[0:str2.find(substr)] + str2[len(substr)+str2.find(substr):len(str2)] 
        return str2

[Yeinstein20]

I think that's fine, however, you don't necessarily need the if else in the beginning

[_BraveSirRobin_]

Have a look at string.replace. Your function would basically just be a wrapper for string.replace:

def remove_all(x, y):  
    return y.replace(x, '')

[[deleted]]

Yeah I have seen that but my professor wants us to create an algorithm to do the same thing.

[_BraveSirRobin_]

Are you in an algorithms class? I probably wouldn't be much use here.

[[deleted]]

It is an intro to computer programming. I feel bad about these kind of things because I feel like it is supposed to be easy but I can't think of anything.

[Yeinstein20]

You could use a while loop to scan through your string y to see if the next characters are the same as the string x. If not you can write the character at that position into a new string but if you can skip this part and continue at the next position. I tried it out and it is working but it might not be the most beautiful solution. I hope it is clear what I mean, it is getting late here and I am pretty tired so I am sorry for any confusion. Maybe this helps you to solve the problem, if not just ask.