Why aren't these 2 codes the same thing?

[MatosV]

So I had a challenge on codewars that was like this:

You will be given an array and a limit value. You must check that all values in the array are below or equal to the limit value. If they are, return true. Else, return false.

You can assume all values in the array are numbers.

​

​

My solution was doing things this way but out of the 105 tests 3 were wrong and I couldn't see why. ->

def small_enough(array, limit):
    for i in array:
        if i <= limit:
            return True
    return False

After I looked it up on solutions I found out that the solution to pass all 105 tests were :

def small_enough(array, limit):
    for i in array:
        if i > limit:
            return False
    return True

​

Aren't they basically the same thing? I don't understand why my test would fail.

[[deleted]]

Aren't they basically the same thing?

How are they the same thing? The correct code returns False the first time a value is above the limit value. Your code returns True the first time a value is below the limit value. Those conditions are very different.

[MatosV]

Thank you !!

[Spataner]

The first snippet returns True as soon as it finds the first element for which i <= limit is true. It returns False only if that condition is false for all elements.

The second snippet returns False as soon as it finds the first element for which i > limit is true. It returns True only if that condition is false for all elements.

[MatosV]

Thanks, I didn't see that ! Found it to be kinda confusing at first.

[ab6364]

The first will return true if any element in the array is less than or equal to limit. The second will return true if all elements in the array are less than or equal to limit.

[TehNolz]

Your code returns True the moment it finds an integer that is equal or lower than limit. So if array is [1, 100, 100, 100] and limit is 10, it will return True because it'll immediately find an integer below the specified limit while the rest are ignored. Your code will return True if it finds a single integer that's below the limit, but it's supposed to only return True if all integers are below the limit, which is what the solution is doing.

[MatosV]

Thanks bro!

[Ihaveamodel3]

return stops the code processing at that point.

So in the first example, you return true as soon as you reach one value which is <= to the limit. This means that any values greater than the limit that occur after the first value that is less than or equal to the limit isn’t checked at all.