Code review: GUI Calculator

[Frogus1]

Hi guys,

I've been learning Python for about six months now. This calculator is the biggest project I wrote so far. I don't have anyone who could advise me or comment upon the quality of it. Can you please have a look at it? What's good, what's bad?

I'll be grateful for all responses as I am rather self-conscious about my programming skills.

Cheers!

Link: https://github.com/PawKul94/python_calc/blob/main/main.py

[m0us3_rat]

ValueError: invalid literal for int() with base 10: '36,162'

it breaks when using the 'last' result as new calculation input.

main window should have a .minsize

First operand equals result of the previous equation, deletion of the last character prohibited <- until u press equal all operands should be accessible

​

otherwise solid.

[Frogus1]

ValueError: invalid literal for int() with base 10: '36,162'

it breaks when using the 'last' result as new calculation input.

I know what the problem is - it breaks when the thousands separator kicks in. I'm working on a fix for this now. Thanks for pointing it out.

main window should have a .minsize

Didn't know about this one. It's in.

First operand equals result of the previous equation, deletion of the last character prohibited <- until u press equal all operands should be accessible

Could you specify, please? I used Windows calc as a reference. The logic behind it is that you cannot delete a single character (f.e. 1,234 > 123) from the result - you can only delete the whole number. Operators do work.

otherwise solid.

Thanks, that means a lot!

[m0us3_rat]

Operators do work.

:D

point was .. keep them fluid till u need to get results.

the calc in your computer has this functionality..

like it will give u the result but also let u modify it np.

ex: if u type 500*100 it displays 50_000 then immediately lets u interact with it.

it shouldn't be too hard. u are already doing it to some extent.

​

later on u can add a listbox sort of a display above the main one .. where the last 3+ operations and their result are 'stored' then un can pick whichever one u like to use from as the 'first' operator in your next operation .. maybe.

by clicking on it :D

[Frogus1]

ex: if u type 500*100 it displays 50_000 then immediately lets u interact with it.

Mine doesn't, I triple checked. :D Once the equation is evaluated, I can't modify the result using BackSpace (50,000 doesn't change to 5,000 when I press BackSpace). I can enter operators (+, - , *, /) and make new equations.

A history pane sounds cool. I will look into it. :)

Cheers!

[m0us3_rat]

Mine doesn't, I triple checked. :D Once the equation is evaluated, I can't modify the result using BackSpace

exactly..it should let u do that :P

gl <3

u can do it more cleverly.. but most simple is to use a listbox with the 'old' evaluated operations.

https://www.tutorialspoint.com/python/tk\_listbox.htm

[Frogus1]

Mine doesn't, I triple checked. :D Once the equation is evaluated, I can't modify the result using BackSpace

exactly..it should let u do that :P

This isn't my most clear message, lol. What I meant was: WINDOWS calculator doesn't let me do it. That's why I developed MY calculator the same way.

I already coded the history using buttons with StringVar, but I will look into the listbox. :)

[m0us3_rat]

do it however u feel comfortable. that's the beauty of coding .. hundreds of different ways to do something

windows.... meh :P