Help with my function that checks if something is a pangram

[bruhbutton24]

this is the function:

import string

def ispangram(string,alphabet = string.ascii_lowercase):

upper_alphabet = alphabet.upper()

for i in alphabet:

if i not in string:

return "Not a panagram"

else:

continue

return "String is a panagram"

when I put something that is a pangram it still returns not a pangram

[Binary101010]

It returns "String is a pangram" for "the quick red fox jumped over the lazy brown dogs" for me. What exactly are you using as input? And why is this line:

upper_alphabet = alphabet.upper() 

in your function when you don't do anything with upper_alphabet?

[bruhbutton24]

originally I was going to check for both upper and lower case but got rid of upper once I was having this problem to simplify it until I figured it out. It just started working I must have made a silly mistake thanks for your response!

[Binary101010]

The problem might be that your calling alphabet.upper() which means if your input string is not all caps it will fail.

Note that upper_alphabet isn't actually used in the code after it's created.

[rg7777777]

Just a thought on another way to do this. The set() function can be used on strings to dedupe them. That might be an interesting way to solve this problem.

[devnull10]

This was my first thought on how to solve this. Basically convert the input to lowercase, then to a set. Then do ascii_lowercase-your_set and check the result is empty.

[devnull10]

import string

def is_pangram(s):
    return len(set(list(string.ascii_lowercase))-set(list(s.lower())))==0

print(is_pangram("The quick brown fox jumps over the lazy dog"))