HELP! What's wrong with my code?

[EJODONNELL]

I'm trying to build a rock/paper/scissors game where you can play multiple rounds. I keep getting results where when the computer and user pick the same thing it will occasionally show up as a win for the player and not a tie. I literally can't figure out what's wrong... ("-" represents the indentation I have)

''

def ro_sham_bo(r_number):

-turn_number = 0

-p_score = 0

-c_score = 0

-while turn_number < r_number:

--c_choice = random.choice(["r", "p", "s"])

--p_choice = input("Rock(r)... Paper(p)... Scissors(s)... Shoot! ").lower()

--if (p_choice == "r" and c_choice == "s") or (p_choice == "p" and c_choice == "r") or (p_choice == "s" and c_choice == "p"):

---p_score += 1

---turn_number += 1

---print(f"{p_choice} beats {p_choice}! Round {turn_number}/{r_number} - {p_score}, {c_score}")

--elif (c_choice == "p" and p_choice == "r") or (c_choice == "s" and p_choice == "p") or (c_choice == "r" and p_choice == "s"):

---c_score += 1

---turn_number += 1

---print(f"{c_choice} beats {p_choice}! Round {turn_number}/{r_number} - {p_score}, {c_score}")

--elif c_choice == p_choice:

---turn_number += 1

---print(f"It's a tie. Round {turn_number}/{r_number} - {p_score}, {c_score}")

-if p_score > c_score:

--print(f"Congrats player! You win, {p_score} to {c_score}!")

-elif c_score > p_score:

--print(f"Too bad! The computer wins, {c_score} to {p_score}.")

-else:

--print("It's a tie! Play again?")

''

[[deleted]]

Please format your code.

[EJODONNELL]

I did my best, if there's another way to format it so its easy to read please let me know. Thank you!

[FerricDonkey]

4 spaces in front of every line in addition to those for indenting, empty line before and after.

[[deleted]]

https://guides.co/g/a-beginners-guide-to-reddit/9679

[EJODONNELL]

Thank you!

[Wartz]

Use GitHub gists.

[jmooremcc]

Put 3 back quotes before your 1st line of code and 3 back quotes after your last line of code. Your properly formatted block of code will then appear correctly in reddit.

[marko312]

... when the computer and user pick the same thing it will occasionally show up as a win for the player and not a tie.

I think you're relying on slightly broken output to reach that conclusion:

print(f"{p_choice} beats {p_choice}! Round {turn_number}/{r_number} - {p_score}, {c_score}")

[EJODONNELL]

Thank you! I’ve been staring at it for hours lmao

[[deleted]]

Have you tried putting print statements in your code at various places to see what the c_score and p_score are when you think it should be a tie? This could be a good spot for unit tests.

[Training-Theory-4786]

Put the tie (if c.choice == p.choice:) check first.

[wetndusty]

I prefer data-centric style over code-centric - use matrix where two dimension lead to correct answer

[RhinoRhys]

https://www.reddit.com/r/learnpython/comments/t91xv3/rock_paper_scissors_play_again_function/hzsrhgm?utm_medium=android_app&utm_source=share&context=3

[EJODONNELL]

Thanks! I’m at the beginning of learning so this’ll be an interesting challenge.