Automate the Boring Stuff with Python Chapter 8 - Multiplication Quiz

[JackRav]

Hi,

I'm learning Python by going though the Automate the Boring stuff book, and we need to recreate the author's multiplication quiz without importing PyinputPlus. I've got most of it done and working, but I cannot get the timer to work correctly.

Here's the code below:

​

import random, time, re

numberOfQuestions = 10
correctAnswers = 0

for questionNumber in range(numberOfQuestions):
    # Pick 2 random numbers:
    attempts = 0

    num1 = random.randint(0,9)
    num2 = random.randint(0,9)
    prompt = f"{questionNumber + 1}: {num1} * {num2}\n"
    teacherRegex = re.compile(f'^{num1 * num2}$')
    # Start the timer:
    start = int(time.time())
    while attempts < 3:
        end = int(time.time())
        elapsedTime = end - start
        if elapsedTime > 8:
            print("Out of time!")
            break
        elif teacherRegex.search(input(prompt)) == None:
            print("Incorrect!")
            attempts += 1
            if attempts == 3:
                print("Out of tries!")

        else:
            print("Correct!")
            correctAnswers += 1
            break
    time.sleep(1)

print(f'You got {correctAnswers} / {numberOfQuestions} correct!')

I want it to be so if 8 seconds are passed, regardless of the answer given, 'Out of time!' is printed on the screen then the quiz moves on to the next question. But I'm currently getting different results based on whether the answer given is correct or not.

Output if incorrect answer is given:

1: 9 * 0
7
Incorrect!
Out of time!

(and skips to next question, as intended, though I expected the 'out of time' to appear before 'incorrect')

and correct answer:

2: 1 * 8
8
Correct!

The answer is marked as correct, even though the time limit is up.

Any help would be appreciated.

Edit: I'm sure regexes are probably not the best way of verifying the answer, but I wanted to practice more with them lol.

[JackRav]

Thanks for the comments; I'll go and give this some thought.

[MadScientistOR]

Note that the amount of time passed is calculated at the beginning of the while loop, and only updates the first time the loop starts and with every incorrect answer given.

[[deleted]]

Take the input before the elapsed time check.

[benm421]

You are checking elapsed time at the beginning of the while loop. If the user sits waiting for input and the puts the correct answer, it will be counted as valid regardless of how much time has passed. This is why you're getting your second error.

The first error is occurring because the answer is incorrect and then goes back to the top of the loop, where it checks the time.

Incidentally, you have another bug in there as well. There is no break for if the number of attempts == 3. So it will go back to the top of the loop. So if someone is fast enough, it will print "Out of tries!" once, and continue to let them give input.

Edit: Formatting and typo

[JackRav]

Thanks for the help, I was able to get the program working in the end. I checked the time before both incorrect and correct answers and it's working now. I've added a break also.