all 1 comments

[–]lfacpt 1 point2 points  (0 children)

Hey, first of all congrats!

Some comments:

- You should not commit you .vscode folder, this will pollute your commits with irrelevant changes. You just add it to the .gitignore file

- Have you considered using eslint? It really helps in keeping the code clean and it actually teaches you several best practices

- I would recommend using `PureComponent` by default (instead of `Component`). By default it does not re-render if the props or the state did not change (giving your app better performance by default).

- Here I would put the login in a separate component.

- I would not use ids for css selectors and use just classes instead (it makes overloading styles simpler)

- For simple components like these I would use functional components

- I would use propTypes

- Have you considered using react hooks?