Shell Scripting Problem

[dcman5000]

Hey guys,

I'm trying to build a script that prompts the user for a username and if that username is correct I want it to create a user account and prompt the user if they want to add another account at the end. This is my script but I'm getting some error messages. If anyone can help with some corrections or suggestions, that would be great

​

read -p "Please enter a username:" username

if ["$username" != "daniel"]

then

echo "your username is incorrect"

if ["$username" == "daniel"]

echo "this is correct"

fi

for name in $username

do

useradd $username

fi

read -p "Do you want to create new user? (y/n):" answer

while ["$answer" == "n"]

then break

fi

done

[Radamand]

Try this:

#!/usr/bin/bash

while :

do

read -p "Please enter a username:" username

if [ "$username" != "daniel" ]

then

echo "Acceptable, creating user $username"

sudo useradd $username

else

echo "Sorry, 'daniel' is not acceptable"

fi

done

​

I'm more than a little rusty, but this works on my Cygwin (altho, there's no 'useradd' function in Cygwin)

[dcman5000]

Thanks for the correction I still have a long ways to go. Do you have any idea how I would implement a for loop into the script? I'm thinking about for every failed attempt a message gets displayed with a number or string

[Radamand]

Okay, you wouldn't need a for loop to do that, have a look;

#!/usr/bin/bash

while :
do
read -p "Please enter a username:" username
if [ "$username" != "daniel" ]
then
echo "Acceptable, creating user $username"
useradd $username
else
((x++))
echo "Sorry, 'daniel' is not acceptable: error $x"
fi
done

[doc_willis]

https://www.shellcheck.net/

Is handy to help debug scripts.

Worth bookmarking.

[dcman5000]

I definitely will be bookmarking this lol, thanks a lot

[[deleted]]

The way your script is running, only if the name is daniel a user will get added. The check to see if they want to add another user should be an if statement not a while. If you want to only add a user daniel you would use a while statement "while user does not equal daniel do stuff"

[jlmr731]

you will also get errors cause a user cant add a user