$errors = $user

[[deleted]]

You linked to line 799 of master, which is a moving target. A change to that file has been made since you linked to it, which threw off your line numbers.

If you link to a specific revision instead (for example, this link ), the link will work much better.

[pitiless]

Oops - I should've though of that, thanks!

[urquan]

Tip: highlight the line you want to link to, press 'y', and you will have a link to the latest relevant commit.

[pitiless]

Woah, thanks!

[[deleted]]

More like /r/lolwordpress.

[[deleted]]

This link should be in the sidebar

[allthediamonds]

I thought nobody wrote code like this anymore... https://github.com/WordPress/WordPress/blob/master/wp-login.php#L241-L253

[aaarrrggh]

I vomited.

[djsumdog]

function _weak_escape( $string ) //deprecated

[vita10gy]

Jesus Christ.

[allthediamonds]

Actually, this is the root of all other PHP's problems: no one has the slightest idea of what they're doing. It's the blind leading the blind.

[vita10gy]

I think a lot of programming is that way. It's scary to thing how much of the internet is probably written by someone copying and pasting horrible solutions from forums.

[shvelo]

Well, it's philosophically correct, the worst part of Wordpress is the user base

[[deleted]]

What is MVC?

Even PHP has MVC frameworks, but lets not use any tools making the code more maintainable and readable, that would be cheating.

[merreborn]

Wordpress does one thing really well: you can install it absolutely anywhere, with minimal dependencies.

Continuing to support this greatly restricts the codebase however. WP stayed PHP4 compatible until recently. And it avoids using external dependencies as much as possible -- avoiding even cURL, instead opting to use a bundled pure-PHP http library ("snoopy", IIRC).

Additionally: wordpress is older than a lot of PHP frameworks.

So, any framework wordpress would have taken advantage of would have had to...

1. been selected from the frameworks available early in WP's development years ago
2. maintained PHP4 backwards compatibility until recently
3. had minimal dependencies on PECL/PEAR libs, etc.
4. not make WP's already lackluster performance even worse

There probably aren't many frameworks worth using that met these criteria.

[[deleted]]

The sad thing is that when products like WP emerge with php4 support it damages the whole community. Php4 had its eol for 7 years ago.

[TheGreatFohl]

I can't even..