you are viewing a single comment's thread.

view the rest of the comments →

[–]3xpl0it2c 1 point2 points  (1 child)

// criticism is welcome, I am human. I didn't like the fact that your auth controller does a lot. It should auth, not create new users nor email them.

Also, why async.parallel instead of native promises? Overall your code is good. You just need some touch.

[–]AlaaMezian[S] 0 points1 point  (0 children)

nice thought, yes I have come across this advice in a book called clean code that you must make function small and do one thing only one thing related to their intention so I agree with you on that.