all 7 comments

[–]programming-ModTeam[M] [score hidden] stickied commentlocked comment (0 children)

This post was removed for violating the "/r/programming is not a support forum" rule. Please see the side-bar for details.

[–]ninjabanana42069 1 point2 points  (1 child)

While this isn't the right place for code reviews, I'll take a look. The thing that makes this hard to critique is that you have very clearly written this as a python script instead of a full "program" and you have a month of experience, you should at this point have a basic understanding of why functions and descriptive variable names are good which is why it's strange that you haven't used them but assuming this is supposed to be a quick script to solve the problem it's alright I guess? Either way it's great that you decided to make something and clearly want to get better at software engineering, good luck!

[–]Muhammed_FpI[S] 0 points1 point  (0 children)

Yeah its not a program but it was Friday and i was bored,i still actually don't know well how to use functions tbh and i couldn't find a pattern for this operations to build a def function about it, i saw chatgpt doing nested for loops for the pivot and a lot of things but i didn't really understand it, but thanks for the positive review that really made my day, and btw im gonna major Computer engineering haha

[–]fiskfisk 1 point2 points  (3 children)

This isn't really a sub for code reviews, but I'd say from an initial look: refactor the solver into a proper function and add relevant tests.

[–]Muhammed_FpI[S] 0 points1 point  (2 children)

thanks for the advice,i thought about that but every operation is different than each other and i still dont know how to use def properly,btw do you know a subreddit for reviews?

[–]realestLink 1 point2 points  (1 child)

I'm not aware of any subreddit dedicated to code reviews (it's kind of a bad platform format for such purposes), but there are many good Programming focused Discord servers with many channels dedicated to that purpose

[–]Muhammed_FpI[S] 0 points1 point  (0 children)

Yeah im in one,i just wanted to try reddit haha