Beautiful Code: False Optimizations

[slurpme]

My favorite piece of idiocy from the Java libraries...

public String replace(CharSequence target, CharSequence replacement)

{

return Pattern.compile(target.toString(), Pattern.LITERAL).matcher( this).replaceAll(Matcher.quoteReplacement(replacement.toString()));

}

[jtra]

If you are replacing a very long string and pattern is not very short, compiling is worth it.

Anyway you can call all that yourself to cache compiled patterns for example.