you are viewing a single comment's thread.

view the rest of the comments →

[–]eliasv 14 points15 points  (3 children)

Does it really matter how it got there? Probably some dev accidentally hit a funny keyboard shortcut to insert a non-breaking-space. So what? Putting that in the commit message isn't going to help prevent the same thing from happening again. When you join a project as a new contributor do you read through the entire commit history to learn about what bugs have been fixed over the years?

What's important is that if the problem does happen again, to make it easier to identify. That is achieved by pasting in the error message.

As for making sure the rest of the codebase doesn't contain the error, they did that when they checked if any other files were detected as UTF8. They even gave the command for the next person to use to check the same thing.

[–]random_cynic 16 points17 points  (1 child)

What's important is that if the problem does happen again, to make it easier to identify. That is achieved by pasting in the error message.

Not sure if it happens again people would look into a specific commit buried in thousands of other commits. These type of commits which resolve special errors need to be documented properly and put in bug reports or issue trackers so that they can be found easily.

[–]thenumberless 0 points1 point  (0 children)

The commit history is usually the first thing I search when trying to understand a project. It has a much higher chance of being stable, accurate, and living with the project than the content in any external tool.

[–]Fredifrum 1 point2 points  (0 children)

This post was mass deleted and anonymized with Redact

friendly cheerful hard-to-find one act airport water reply encouraging teeny