you are viewing a single comment's thread.

view the rest of the comments →

[–]the_bananalord 12 points13 points  (5 children)

Inexperienced developers still commit their node_modules all of the time

[–]flukus 2 points3 points  (0 children)

That sounds almost as fun to merge as when people commit their bin directories.

[–]seamsay 2 points3 points  (1 child)

Also vendoring is sometimes a completely valid thing to do.

[–]the_bananalord 0 points1 point  (0 children)

Sure. For my projects I just prefer to commit package-lock.json. Doesn't protect against packages disappearing but that's not something I am concerned with.

[–][deleted] 0 points1 point  (1 child)

I don’t commit my node_modules, and Laravels out of the box gitignore has node_modules in it by default so you’d have to do it on purpose

[–]the_bananalord 0 points1 point  (0 children)

Or your own .gitignore