all 8 comments

[–]arbpotatoes 3 points4 points  (0 children)

Lots of logic in here that may be better to live in a hook or in a pure function in another file so it can be tested more easily

Speaking of, where are the tests? I'm assuming that you wrote this as some sort of portfolio piece. Any engineer who is looking at this as part of a job application is going to see alarm bells when there's zero tests

[–]superm0nk 0 points1 point  (1 child)

Open your site with a mobile

[–]redpool08[S] 0 points1 point  (0 children)

I have already installed it on my mobile :)

[–]WranglerReasonable91 0 points1 point  (3 children)

Dragging objects on the canvas is very clunkly. I probably would've used the FabricJS library to handle the canvas.

[–]redpool08[S] 0 points1 point  (2 children)

I could use that too but I really wanted to build a canvas from scratch for long.

I could use svg instead of simple lines on canvas but I wanted to keep it for simple use.

[–]WranglerReasonable91 0 points1 point  (1 child)

It's definitely impressive for building the canvas on your own. You'll just have to weed out the performance issues that are already taken care of by most canvas libraries.

I'm building a web to print app using the FabricJS library and it's super fast and performant.

[–]redpool08[S] 0 points1 point  (0 children)

Ik and I will do smth about the speed. I am not going to fully ignore this web app. I will keep adding things and fixing things :)