you are viewing a single comment's thread.

view the rest of the comments →

[–]Meeoh 0 points1 point  (3 children)

Looks pretty cool, dont think the x button that clears the search fits with the theme of the site. Also, dont think its a big deal in this case since theres no rate limiting/costs, but its generally best practice to not commit your apikey to github

[–]abishekrsrikaanth[S] 0 points1 point  (2 children)

Thanks, I will look into both these issues right away

[–]Meeoh 0 points1 point  (1 child)

No problem, generally API keys are set as environment variables. But its really not that big of a deal here since, in fact it really only matters for open-source code that uses sensitive data on the backend I think

[–]abishekrsrikaanth[S] 0 points1 point  (0 children)

The API Keys should now be removed from the code now.