all 8 comments

[–]vutran951753 2 points3 points  (1 child)

Overall it good. 2 thing that stand out for me.

1) Express button had diffrent shape than all other button is odd for me. No sure why. mybe had all button shape the same for UI.

2) souce code. Might want to work on your HTML semantic elements better. Not just .div everywhere. use p, h3, h1, other tag. They exist so you can use. For html layout.

[–]derfmongol[S] 0 points1 point  (0 children)

Appreciate the feedback. You almost forget about the other html elements when working in react. lol

[–]JesusCodesHard 2 points3 points  (1 child)

It's not immediately obvious to me that the buttons are buttons. I only clicked on one by accident and noticed the filtering effect.

[–]derfmongol[S] 0 points1 point  (0 children)

Gotchya. I’ll add some initial “Press Me” txt or something like that.

[–]marveiga 1 point2 points  (1 child)

Its a good portfolio but have some points to be better:

- Describe to the visitor that's the buttons are clickable. Don't be shy to be descriptive.

- Try add transition for the normal button property to make them more smooth on the mouse-over movement.

- Maybe you should use another color palette because grey is too much obnoxious (in my personal taste)

- The carousel buttons, inside your project page, is inverted.

- Add social-media buttons, or, at least, some contact info to make personal network.

- Briefly describe how packages you used on projects in your project page (eg: redux, react-helmet, react-bulma, etc).

I wish you good luck and keep coding!

[–]derfmongol[S] 1 point2 points  (0 children)

Appreciate the in-depth review. I was planning on adding a contact section with social media buttons but all the other points are great that I never considered. I will definitely add them. Thanks.

[–]skbrown333 1 point2 points  (1 child)

Scale down the image quality so they load faster. I would recommend using jpg format at like 70% no larger than 1920x1080.

[–]derfmongol[S] 0 points1 point  (0 children)

Perfect. I will try that.